devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
	Rob Herring <robh+dt@kernel.org>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Maxime Ripard <maxime@cerno.tech>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/9] ARM: dts: bcm2711: fix MDIO #address- and #size-cells
Date: Thu, 5 Aug 2021 02:08:16 -0700	[thread overview]
Message-ID: <4ebd90ac-2845-2ad8-5f77-6ec44cbfc6b7@gmail.com> (raw)
In-Reply-To: <1627820932-7247-3-git-send-email-stefan.wahren@i2se.com>



On 8/1/2021 5:28 AM, Stefan Wahren wrote:
> The values of #address-cells and #size-cells are swapped. Fix this
> and avoid the following DT schema warnings for mdio@e14:
> 
>   #address-cells:0:0: 1 was expected
>   #size-cells:0:0: 0 was expected
> 
> Fixes: be8af7a9e3cc ("ARM: dts: bcm2711-rpi-4: Enable GENET support")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Yes this was definitively an error thanks!

> ---
>   arch/arm/boot/dts/bcm2711.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index afe0ef8..55022fc 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -532,8 +532,8 @@
>   				compatible = "brcm,genet-mdio-v5";
>   				reg = <0xe14 0x8>;
>   				reg-names = "mdio";
> -				#address-cells = <0x0>;
> -				#size-cells = <0x1>;
> +				#address-cells = <0x1>;
> +				#size-cells = <0x0>;
>   			};
>   		};
>   	};
> 

-- 
Florian

  reply	other threads:[~2021-08-05  9:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01 12:28 [PATCH 0/9] ARM: dts: Add Raspberry Pi CM4 & CM4 IO Board support Stefan Wahren
2021-08-01 12:28 ` [PATCH 1/9] ARM: dts: bcm2711: fix emmc2bus node name Stefan Wahren
2021-08-02 10:25   ` Marc Zyngier
2021-08-01 12:28 ` [PATCH 2/9] ARM: dts: bcm2711: fix MDIO #address- and #size-cells Stefan Wahren
2021-08-05  9:08   ` Florian Fainelli [this message]
2021-08-01 12:28 ` [PATCH 3/9] ARM: dts: bcm2711-rpi-4-b: fix sd_io_1v8_reg regulator states Stefan Wahren
2021-08-01 12:28 ` [PATCH 4/9] dt-bindings: display: bcm2835: add optional property power-domains Stefan Wahren
2021-08-06 21:11   ` Rob Herring
2021-08-01 12:28 ` [PATCH 5/9] ARM: dts: bcm283x-rpi: Move Wifi/BT into separate dtsi Stefan Wahren
2021-08-01 12:28 ` [PATCH 6/9] dt-bindings: arm: bcm2835: Add Raspberry Pi Compute Module 4 Stefan Wahren
2021-08-06 21:12   ` Rob Herring
2021-08-01 12:28 ` [PATCH 7/9] ARM: dts: " Stefan Wahren
2021-08-01 12:28 ` [PATCH 8/9] ARM: dts: Add Raspberry Pi Compute Module 4 IO Board Stefan Wahren
2021-08-01 12:28 ` [PATCH 9/9] arm64: dts: broadcom: Add reference to RPi CM4 " Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ebd90ac-2845-2ad8-5f77-6ec44cbfc6b7@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maxime@cerno.tech \
    --cc=nsaenz@kernel.org \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).