From: Stephen Boyd <sboyd@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] of/platform: Fix inverted check in of_platform_notify()
Date: Tue, 16 Jul 2024 11:26:51 -0700 [thread overview]
Message-ID: <4edc5e10f4407c281960dad69d7f463b.sboyd@kernel.org> (raw)
In-Reply-To: <a9ada686e1f1c6f496e423deaf108f1bcfd94d7d.1721123679.git.geert+renesas@glider.be>
Quoting Geert Uytterhoeven (2024-07-16 02:57:25)
> The check for of_node_check_flag() was accidentally inverted, causing
> i2c-demux-pinctrl to fail on the Koelsch development board:
>
> i2c-demux-pinctrl i2c-mux1: failed to setup demux-adapter 0 (-19)
> i2c-demux-pinctrl i2c-mux2: failed to setup demux-adapter 0 (-19)
> i2c-demux-pinctrl i2c-mux3: failed to setup demux-adapter 0 (-19)
> i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with e6ef0000.video
> i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with e6ef1000.video
> i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with hdmi-in
> i2c-demux-pinctrl i2c-mux2: Failed to create device link (0x180) with hdmi-out
>
> and anything relying on I2C connected to these muxes fails, too.
>
> Also, loading the 25LC040 DT overlay on Ebisu using the out-of-tree
> of-configfs now fails, too.
>
> Fixes: 98290f295fbcf18f ("of/platform: Allow overlays to create platform devices from the root node")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Thanks. I'm going to fold this into the patch and resend the series.
prev parent reply other threads:[~2024-07-16 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 9:57 [PATCH] of/platform: Fix inverted check in of_platform_notify() Geert Uytterhoeven
2024-07-16 18:26 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4edc5e10f4407c281960dad69d7f463b.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).