From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] media: dt-binding: media: Add rockchip-vepu binding
Date: Mon, 13 Jun 2022 11:43:58 +0200 [thread overview]
Message-ID: <4ee7e805-d4ed-a765-6b5f-c78183a64fe7@linaro.org> (raw)
In-Reply-To: <1885873.U9Vi27CkfU@archbook>
On 12/06/2022 17:05, Nicolas Frattaroli wrote:
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: aclk
>>> + - const: hclk
>>
>> Since these are new bindings, it would be good to follow DT convention
>> and not add common "clk" prefix to clocks. Just like DMA is "tx" not
>> "txdma". However clock names "a" and "h" are also not good and maybe
>> this is already shared implementation?
>
> This is indeed a shared implementation. Theoretically I could change
> the driver for this one case but that seems pointless, especially
> since "aclk" and "hclk" are the usual clk names for AXI and AHB on
> ARM as far as I understand. I think I've been told before that those
> two clocks should always be called aclk and hclk.
>
ok
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-13 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 13:36 [PATCH v4 0/3] Enable JPEG Encoder on RK3566/RK3568 Nicolas Frattaroli
2022-05-14 13:36 ` [PATCH v4 1/3] media: dt-binding: media: Add rockchip-vepu binding Nicolas Frattaroli
2022-05-14 20:41 ` Krzysztof Kozlowski
2022-06-12 15:05 ` Nicolas Frattaroli
2022-06-13 9:43 ` Krzysztof Kozlowski [this message]
2022-05-14 13:36 ` [PATCH v4 3/3] arm64: dts: rockchip: Add Hantro encoder node to rk356x Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ee7e805-d4ed-a765-6b5f-c78183a64fe7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).