From: Florian Fainelli <f.fainelli@gmail.com>
To: "Philipp Zabel" <p.zabel@pengutronix.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 2/2] reset: brcm-pmb: add driver for Broadcom's PMB
Date: Tue, 8 Dec 2020 12:20:14 -0800 [thread overview]
Message-ID: <4eeb0a1c-75e4-94ad-8fbb-aeb347aea5d0@gmail.com> (raw)
In-Reply-To: <d5162eae806f21f583c6dbdf7bb79384a3d9d5cf.camel@pengutronix.de>
On 12/8/20 3:02 AM, Philipp Zabel wrote:
> Hi Rafał,
>
> On Thu, 2020-11-19 at 13:56 +0100, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138).
>> It's needed to power on and off SoC blocks like PCIe, SATA, USB.
>
> This sentence, the register names, and
> the brcm_pmb_power_on/off_device/zone functions below make me worry that
> this should be a power domain controller (pm_genpd in drivers/soc)
> instead.
> Does PM in PMB stand for power management by chance?
It does, PMB stands for Power Management Bus.
>
> If this actually cuts power to the USB and PCIe cores instead of just
> controlling reset lines, it would be better to implement this
> differently.
What is tricky is this is a combined reset/clock/power zones controller.
You rarely turn off/assert one of those without also turning
off/asserting the others.
--
Florian
next prev parent reply other threads:[~2020-12-08 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 12:55 [PATCH V2 0/2] reset: support Broadcom's PMB Rafał Miłecki
2020-11-19 12:55 ` [PATCH V2 1/2] dt-bindings: reset: document Broadcom's PMB binding Rafał Miłecki
2020-12-07 22:05 ` Rob Herring
2020-11-19 12:56 ` [PATCH V2 2/2] reset: brcm-pmb: add driver for Broadcom's PMB Rafał Miłecki
2020-12-08 11:02 ` Philipp Zabel
2020-12-08 20:20 ` Florian Fainelli [this message]
2020-12-09 11:24 ` Philipp Zabel
2020-12-11 11:34 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eeb0a1c-75e4-94ad-8fbb-aeb347aea5d0@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).