* Re: [PATCH] platform: Explicitly include correct DT includes
2023-07-14 17:49 [PATCH] platform: Explicitly include correct DT includes Rob Herring
@ 2023-07-17 3:50 ` Tzung-Bi Shih
2023-07-26 8:59 ` Hans de Goede
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Tzung-Bi Shih @ 2023-07-17 3:50 UTC (permalink / raw)
To: Rob Herring
Cc: Benson Leung, Guenter Roeck, Hans de Goede, Mark Gross,
Vadim Pasternak, devicetree, chrome-platform, linux-kernel,
platform-driver-x86
On Fri, Jul 14, 2023 at 11:49:09AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
For cros_ec:
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
The driver uses platform_device_unregister() which is in platform_device.h.
> diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
> index 8b7949220382..5d36fbc75e1b 100644
> --- a/drivers/platform/chrome/cros_ec.c
> +++ b/drivers/platform/chrome/cros_ec.c
> @@ -12,6 +12,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_platform.h>
> +#include <linux/platform_device.h>
> #include <linux/platform_data/cros_ec_commands.h>
> #include <linux/platform_data/cros_ec_proto.h>
> #include <linux/slab.h>
nit: if we want to maintain the sort, "platform_device" should come after
"platform_data".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] platform: Explicitly include correct DT includes
2023-07-14 17:49 [PATCH] platform: Explicitly include correct DT includes Rob Herring
2023-07-17 3:50 ` Tzung-Bi Shih
@ 2023-07-26 8:59 ` Hans de Goede
2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
3 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2023-07-26 8:59 UTC (permalink / raw)
To: Rob Herring, Benson Leung, Guenter Roeck, Mark Gross,
Vadim Pasternak
Cc: devicetree, chrome-platform, linux-kernel, platform-driver-x86
Hi,
On 7/14/23 19:49, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/chrome/cros_ec.c | 1 +
> drivers/platform/mellanox/mlxreg-hotplug.c | 1 -
> drivers/platform/mellanox/mlxreg-io.c | 1 -
> 3 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
> index 8b7949220382..5d36fbc75e1b 100644
> --- a/drivers/platform/chrome/cros_ec.c
> +++ b/drivers/platform/chrome/cros_ec.c
> @@ -12,6 +12,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_platform.h>
> +#include <linux/platform_device.h>
> #include <linux/platform_data/cros_ec_commands.h>
> #include <linux/platform_data/cros_ec_proto.h>
> #include <linux/slab.h>
> diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
> index b7dcc64cd238..6ddfea0d4c5b 100644
> --- a/drivers/platform/mellanox/mlxreg-hotplug.c
> +++ b/drivers/platform/mellanox/mlxreg-hotplug.c
> @@ -12,7 +12,6 @@
> #include <linux/i2c.h>
> #include <linux/interrupt.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> #include <linux/platform_data/mlxreg.h>
> #include <linux/platform_device.h>
> #include <linux/spinlock.h>
> diff --git a/drivers/platform/mellanox/mlxreg-io.c b/drivers/platform/mellanox/mlxreg-io.c
> index ddc08abf398c..83ba037408cd 100644
> --- a/drivers/platform/mellanox/mlxreg-io.c
> +++ b/drivers/platform/mellanox/mlxreg-io.c
> @@ -11,7 +11,6 @@
> #include <linux/hwmon.h>
> #include <linux/hwmon-sysfs.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> #include <linux/platform_data/mlxreg.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform: Explicitly include correct DT includes
2023-07-14 17:49 [PATCH] platform: Explicitly include correct DT includes Rob Herring
2023-07-17 3:50 ` Tzung-Bi Shih
2023-07-26 8:59 ` Hans de Goede
@ 2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-09-11 4:31 UTC (permalink / raw)
To: Rob Herring
Cc: bleung, groeck, hdegoede, markgross, vadimp, devicetree,
chrome-platform, linux-kernel, platform-driver-x86
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Hans de Goede <hdegoede@redhat.com>:
On Fri, 14 Jul 2023 11:49:09 -0600 you wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> [...]
Here is the summary with links:
- platform: Explicitly include correct DT includes
https://git.kernel.org/chrome-platform/c/b9fe9c9ef97d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] platform: Explicitly include correct DT includes
2023-07-14 17:49 [PATCH] platform: Explicitly include correct DT includes Rob Herring
` (2 preceding siblings ...)
2023-09-11 4:31 ` patchwork-bot+chrome-platform
@ 2023-09-11 4:49 ` patchwork-bot+chrome-platform
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-09-11 4:49 UTC (permalink / raw)
To: Rob Herring
Cc: bleung, groeck, hdegoede, markgross, vadimp, devicetree,
chrome-platform, linux-kernel, platform-driver-x86
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Hans de Goede <hdegoede@redhat.com>:
On Fri, 14 Jul 2023 11:49:09 -0600 you wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> [...]
Here is the summary with links:
- platform: Explicitly include correct DT includes
https://git.kernel.org/chrome-platform/c/b9fe9c9ef97d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread