devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chukun Pan <amadeus@jmu.edu.cn>, Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: ipq6018: enable sdhci node
Date: Wed, 10 Jan 2024 16:22:50 +0100	[thread overview]
Message-ID: <4f070678-63b6-4657-ad4f-c32256adbf1f@linaro.org> (raw)
In-Reply-To: <20240110151040.2155938-3-amadeus@jmu.edu.cn>

On 10/01/2024 16:10, Chukun Pan wrote:
> Enable mmc device found on ipq6018 devices.
> This node supports both eMMC and SD cards.
> 
> Tested with:
>   eMMC (HS200)
>   SD Card (SDR50/SDR104)

How? It is disabled...

...

> +
> +			clocks = <&gcc GCC_SDCC1_AHB_CLK>,
> +				 <&gcc GCC_SDCC1_APPS_CLK>,
> +				 <&xo>;
> +			clock-names = "iface", "core", "xo";
> +			resets = <&gcc GCC_SDCC1_BCR>;
> +			max-frequency = <192000000>;
> +			mmc-ddr-1_8v;
> +			mmc-hs200-1_8v;

Aren't these three properties of the board?

Best regards,
Krzysztof


  reply	other threads:[~2024-01-10 15:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 15:10 [PATCH v2 0/2] arm64: dts: qcom: ipq8074: add MicroSD node Chukun Pan
2024-01-10 15:10 ` [PATCH v2 1/2] arm64: dts: qcom: ipq6018: add LDOA2 regulator Chukun Pan
2024-01-11 12:19   ` Konrad Dybcio
2024-01-14  8:30     ` Chukun Pan
2024-01-10 15:10 ` [PATCH v2 2/2] arm64: dts: qcom: ipq6018: enable sdhci node Chukun Pan
2024-01-10 15:22   ` Krzysztof Kozlowski [this message]
2024-01-11  3:10     ` Chukun Pan
2024-01-11  8:01       ` Krzysztof Kozlowski
2024-01-11 11:20         ` Chukun Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f070678-63b6-4657-ad4f-c32256adbf1f@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=amadeus@jmu.edu.cn \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).