From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sergiu Moga <sergiu.moga@microchip.com>,
lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com,
radu_nicolae.pirea@upb.ro, richard.genoud@gmail.com,
gregkh@linuxfoundation.org, broonie@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, jirislaby@kernel.org,
admin@hifiphile.com, kavyasree.kotagiri@microchip.com,
tudor.ambarus@microchip.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-serial@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 06/14] dt-bindings: serial: atmel,at91-usart: convert to json-schema
Date: Tue, 13 Sep 2022 16:28:17 +0200 [thread overview]
Message-ID: <4f201ad4-ea4a-43af-9ec8-c2a3c1b80d2c@linaro.org> (raw)
In-Reply-To: <20220913142205.162399-7-sergiu.moga@microchip.com>
On 13/09/2022 16:21, Sergiu Moga wrote:
> Convert at91 USART DT Binding for Atmel/Microchip SoCs to
> json-schema format. Furthermore, move this binding to the
> serial directory, since binding directories match hardware,
> unlike the driver subsystems which match Linux convention.
>
> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
> ---
>
>
> v1 -> v2:
> - only do what the commit says, split the addition of other compatibles and
> properties in other patches
> - remove unnecessary "|"'s
> - mention header in `atmel,usart-mode`'s description
> - place `if:` under `allOf:`
> - respect order of spi0's DT properties: compatible, then reg then the reset of properties
>
> v2 -> v3:
> - Previously [PATCH 5]
> - Check value of `atmel,usart-mode` instead of the node regex
> - Define all properties top level and disallow them explicitly for other type,
> since additionalProperties:false conflicts with referencing other schemas
> - Remove useless else if: after else:
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-13 15:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 14:21 [PATCH v3 00/14] Make atmel serial driver aware of GCLK Sergiu Moga
2022-09-13 14:21 ` [PATCH v3 01/14] ARM: dts: at91: sama7g5: Swap rx and tx for spi11 Sergiu Moga
2022-09-16 8:13 ` Claudiu.Beznea
2022-09-13 14:21 ` [PATCH v3 02/14] ARM: dts: at91: sam9x60ek: Add DBGU compatibles to uart1 Sergiu Moga
2022-09-16 8:14 ` Claudiu.Beznea
2022-09-13 14:21 ` [PATCH v3 03/14] ARM: dts: at91: Add `atmel,usart-mode` required property to serial nodes Sergiu Moga
2022-09-16 8:15 ` Claudiu.Beznea
2022-09-13 14:21 ` [PATCH v3 04/14] spi: dt-bindings: atmel,at91rm9200-spi: Add DMA related properties Sergiu Moga
2022-09-16 8:15 ` Claudiu.Beznea
2022-09-13 14:21 ` [PATCH v3 05/14] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding Sergiu Moga
2022-09-13 14:21 ` [PATCH v3 06/14] dt-bindings: serial: atmel,at91-usart: convert to json-schema Sergiu Moga
2022-09-13 14:28 ` Krzysztof Kozlowski [this message]
2022-09-13 14:21 ` [PATCH v3 07/14] dt-bindings: serial: atmel,at91-usart: Add SAM9260 compatibles to SAM9X60 Sergiu Moga
2022-09-13 14:28 ` Krzysztof Kozlowski
2022-09-13 14:22 ` [PATCH v3 08/14] dt-bindings: mfd: atmel,sama5d2-flexcom: Add USART child node ref binding Sergiu Moga
2022-09-13 14:29 ` Krzysztof Kozlowski
2022-09-13 14:22 ` [PATCH v3 09/14] dt-bindings: serial: atmel,at91-usart: Add gclk as a possible USART clock Sergiu Moga
2022-09-13 14:29 ` Krzysztof Kozlowski
2022-09-13 14:22 ` [PATCH v3 10/14] tty: serial: atmel: Define GCLK as USART baudrate source clock Sergiu Moga
2022-09-13 14:22 ` [PATCH v3 11/14] tty: serial: atmel: Define BRSRCCK bitmask of UART IP's Mode Register Sergiu Moga
2022-09-13 14:22 ` [PATCH v3 12/14] tty: serial: atmel: Only divide Clock Divisor if the IP is USART Sergiu Moga
2022-09-14 11:01 ` Ilpo Järvinen
2022-09-14 12:17 ` Sergiu.Moga
2022-09-13 14:22 ` [PATCH v3 13/14] clk: at91: sama5d2: Add Generic Clocks for UART/USART Sergiu Moga
2022-09-16 8:16 ` Claudiu.Beznea
2022-09-13 14:22 ` [PATCH v3 14/14] tty: serial: atmel: Make the driver aware of the existence of GCLK Sergiu Moga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f201ad4-ea4a-43af-9ec8-c2a3c1b80d2c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=admin@hifiphile.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kavyasree.kotagiri@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sergiu.moga@microchip.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).