From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4366C07E9D for ; Fri, 23 Sep 2022 18:16:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232754AbiIWSQF (ORCPT ); Fri, 23 Sep 2022 14:16:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230207AbiIWSQE (ORCPT ); Fri, 23 Sep 2022 14:16:04 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AB74814FB for ; Fri, 23 Sep 2022 11:16:02 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id f9so1547116lfr.3 for ; Fri, 23 Sep 2022 11:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=oCR6Bo3A4ofjsJSPRwu8W/6xTMTPUToxbtx6duza/9I=; b=QTFH6A6ALvOnrxdBlLXWwrPn4QlREymvd6XMlcentLZ7h/3fide79fdoCHB5KTem71 yp6pWhrM2z41mtYT5qLU1Bh2iz6CQHypAeyWgu+d26gmF+IBSGIswW9vQE8qWgJ374M4 J/sKG8vfLGHmHmWMmL0qpwPd+e/Bj/iWmYCd/15aKADo++tGMLkwakMCAyWOepF0i+ri dgeTUxMR2PMwWHVfXToHcEn+O+6EOAZsDDngC6NZ/U5fhtxvtdPZuOdXrK0VhBLVtBA2 3FBSeqMz0DB1naWCCiR7W8HX0k883wfgPGcd/oly/dmRrF0ooaifWb7Sstlh8ULCJj1C B7+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=oCR6Bo3A4ofjsJSPRwu8W/6xTMTPUToxbtx6duza/9I=; b=4CslGMj9nIj6B4cboM2a7I8cSQeC5eeh1UxKkW5uinrc8ZUl01qSECuQsfpWiur1ve msNFh9I/acpnUNK5eHiaJ3ZUUf/iCl7x8u/K4uGh84RsFNE5Ky8V2bMeXP1w3GbEOD3g gug4GTuIBDRe+Jlpc8AjL72L9CGbHM1HvqcJrigUTSamAvbVHtLhJondNSJmtapCSyqL ue3n+YVPWChrCfdD1/fZHpLjqG1rY6angDr6ZwiQLOJ1O8BMc9K9hJnDYBCFR1IXRnWF ubAcg3iwbCaLdaBD5n76gTzdJSxRHYo/H/IJMgB6ooKp0bUCGIbjl9xlI0LLj+s4OrGF jDkw== X-Gm-Message-State: ACrzQf3dw11jh1oMGZFZWCGcdN1a7Y8H2OL6XZHTbXkiHfqfUrgDcdoq 9KPSoyeWQy6RoSNhHyEy7ZUOqg== X-Google-Smtp-Source: AMsMyM5VPQHR6EgWnlQIIyiIzzfK4PFaph4377Xhq50FxdoZgzoCfLawcTAmFyxngXUm5xjobVChzg== X-Received: by 2002:a05:6512:3295:b0:497:a156:795a with SMTP id p21-20020a056512329500b00497a156795amr3537914lfe.345.1663956960760; Fri, 23 Sep 2022 11:16:00 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id j5-20020a2e6e05000000b0026c59d3f557sm1487798ljc.33.2022.09.23.11.15.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 11:16:00 -0700 (PDT) Message-ID: <4f205f0d-420d-8f51-ad26-0c2475c0decd@linaro.org> Date: Fri, 23 Sep 2022 20:15:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v5 4/4] net: stmmac: Update the name of property 'clk_csr' Content-Language: en-US From: Krzysztof Kozlowski To: AngeloGioacchino Del Regno , Jianguo Zhang , "David S . Miller" , Rob Herring , Krzysztof Kozlowski Cc: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Matthias Brugger , Biao Huang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220923052828.16581-1-jianguo.zhang@mediatek.com> <20220923052828.16581-5-jianguo.zhang@mediatek.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/09/2022 20:14, Krzysztof Kozlowski wrote: >> This is going to break MT2712e on old devicetrees. >> >> The right way of doing that is to check the return value of of_property_read_u32() >> for "snps,clk-csr": if the property is not found, fall back to the old "clk_csr". > > I must admit - I don't care. That's the effect when submitter bypasses > DT bindings review (81311c03ab4d ("net: ethernet: stmmac: add management > of clk_csr property")). > > If anyone wants ABI, please document the properties. > > If out-of-tree users complain, please upstream your DTS or do not use > undocumented features... > OTOH, as Angelo pointed out, handling old and new properties is quite easy to achieve, so... :) Best regards, Krzysztof