From: Andrea Greco <andrea.greco.gapmilano@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: "Tobin C. Harding" <tobin@apporbit.com>,
Andrea Greco <a.greco@4sigma.it>,
Mark Rutland <mark.rutland@arm.com>,
netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] arcnet: com20020: bindings for smsc com20020
Date: Wed, 30 May 2018 16:07:22 +0200 [thread overview]
Message-ID: <4f6cda28-478e-1af8-4a63-2165298cabcb@gmail.com> (raw)
In-Reply-To: <CAL_JsqL1M3SuH_cJGUhh0+Xg+UYDjAc-=a+USENOKznvWib1Ng@mail.gmail.com>
On 05/24/2018 04:36 PM, Rob Herring wrote> If you want to add it, that's
fine. But it's really not something that
> comes up often. For UARTs, there's already the "current-speed"
> property and most other things I can think of use Hz to express
> speeds.
No, Pref keep standard and use Hz.
This if finally:
```
SMSC com20020 Arcnet network controller
Required property:
- timeout-ns: Arcnet bus timeout, Idle Time (328000 - 20500)
- bus-speed-bps: Arcnet bus speed (10000000 - 156250)
- smsc,xtal-mhz: External oscillator frequency
- smsc,backplane-enabled: Controller use backplane mode
- reset-gpios: Chip reset pin
- interrupts: Should contain controller interrupt
arcnet@28000000 {
compatible = "smsc,com20020";
timeout-ns = <20500>;
bus-speed-hz = <10000000>;
smsc,xtal-mhz = <20>;
smsc,backplane-enabled;
reset-gpios = <&gpio3 21 GPIO_ACTIVE_LOW>;
interrupts = <&gpio2 10 GPIO_ACTIVE_LOW>;
};
```
If confirmed, for me is right
Andrea
prev parent reply other threads:[~2018-05-30 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 13:06 [PATCH 2/4] arcnet: com20020: bindings for smsc com20020 Andrea Greco
2018-05-23 16:49 ` Rob Herring
2018-05-23 22:17 ` Andrea Greco
2018-05-24 14:36 ` Rob Herring
2018-05-30 14:07 ` Andrea Greco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f6cda28-478e-1af8-4a63-2165298cabcb@gmail.com \
--to=andrea.greco.gapmilano@gmail.com \
--cc=a.greco@4sigma.it \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tobin@apporbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).