From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy-h8G6r0blFSE@public.gmane.org Subject: Re: [PATCH v5 01/10] arm64: allwinner: a64: enable RSB on A64 Date: Fri, 28 Apr 2017 02:14:58 +0800 Message-ID: <4f910cd7ab972c1b6d93b0327833b596@aosc.io> References: <20170426152023.41567-1-icenowy@aosc.io> <20170426152023.41567-2-icenowy@aosc.io> <20170427132805.izv6xfktlhfc4yty@lukather> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170427132805.izv6xfktlhfc4yty@lukather> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maxime Ripard Cc: Thomas Gleixner , Rob Herring , Chen-Yu Tsai , Lee Jones , Liam Girdwood , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-kernel-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org 在 2017-04-27 21:28，Maxime Ripard 写道： > On Wed, Apr 26, 2017 at 11:20:14PM +0800, Icenowy Zheng wrote: >> Allwinner A64 have a RSB controller like the one on A23/A33 SoCs. >> >> Add it and its pinmux. >> >> Signed-off-by: Icenowy Zheng >> Acked-by: Chen-Yu Tsai >> --- >> Changes in v2: >> - Removed bonus properties in pio node. >> - Added Chen-Yu's ACK. >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19 >> +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> index c7f669f5884f..05ec9fc5e81f 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> @@ -422,6 +422,25 @@ >> #gpio-cells = <3>; >> interrupt-controller; >> #interrupt-cells = <3>; >> + >> + r_rsb_pins: rsb@0 { >> + pins = "PL0", "PL1"; >> + function = "s_rsb"; >> + }; >> + }; >> + >> + r_rsb: rsb@1f03400 { >> + compatible = "allwinner,sun8i-a23-rsb"; >> + reg = <0x01f03400 0x400>; >> + interrupts = ; >> + clocks = <&r_ccu 6>; > > Please use the defines here.. Linux-4.12 doesn't yet enter rc1, and the defines are still not in Linus's tree. Please note that I have already mentioned that this patch is necessary to be merged into 4.12, otherwise poweroff won't work properly at 4.12 . So I think it shouldn't still use defines. I will fix here after 4.12-rc1 is out, along with other r_ccu usages. > >> + clock-frequency = <3000000>; >> + resets = <&r_ccu 2>; > > And here. > > Thanks! > Maxime -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html