From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C27FA3741 for ; Sat, 29 Oct 2022 00:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229456AbiJ2AEB (ORCPT ); Fri, 28 Oct 2022 20:04:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiJ2AEA (ORCPT ); Fri, 28 Oct 2022 20:04:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258F71F527F; Fri, 28 Oct 2022 17:04:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B678E62B28; Sat, 29 Oct 2022 00:03:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F59DC433C1; Sat, 29 Oct 2022 00:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667001839; bh=8+9R9gDIJ/W0YoiM2ajpmy9KkYOG9Pgge4BcaswvFNc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z5xzl+e1CHM/j6Z845Zw/o/Mvytjfro2i96voHFOEYewSj0U21V3IgUGaCEBfkz7/ EI5Xo8zO+gCWLQ0JI7Eo8doEQXviz0InQFf1QODluVbsCzOn+y/N7nLPXI9Unk273d f8/8cpwPN5RXlkiydkvM3C4goHxFoOY9hAeDypgiw+HTW/rxJbtjx37pRVmbfTVCSh 0ebFSrhw1TIYk6ByyJd2L2jYH5jF2Ppb3ZN3EjZz3w4B3mgUFnIhqnDCLNoxFJsXxd uGTC8vtwe0TSkLf4jurqiD9Cxh+rbRsiaCXSz8S8Tr7ddYA9vKYVVJBtJdn6e0Wkmc ceXrUMmkxmHSA== Message-ID: <4f9f6fcf-b6f2-7729-5950-7bc472d0c863@kernel.org> Date: Fri, 28 Oct 2022 20:03:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2 net-next 1/6] arm64: dts: mediatek: mt7986: add support for RX Wireless Ethernet Dispatch Content-Language: en-US To: Lorenzo Bianconi , netdev@vger.kernel.org Cc: nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, lorenzo.bianconi@redhat.com, Bo.Jiao@mediatek.com, sujuan.chen@mediatek.com, ryder.Lee@mediatek.com, evelyn.tsai@mediatek.com, devicetree@vger.kernel.org, robh@kernel.org, daniel@makrotopia.org References: <41d67d36481f3099f953a462a80e99a4fcd477dd.1666549145.git.lorenzo@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <41d67d36481f3099f953a462a80e99a4fcd477dd.1666549145.git.lorenzo@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/10/2022 14:28, Lorenzo Bianconi wrote: > Similar to TX Wireless Ethernet Dispatch, introduce RX Wireless Ethernet > Dispatch to offload traffic received by the wlan interface to lan/wan > one. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > > Co-developed-by: Sujuan Chen > Signed-off-by: Sujuan Chen > Signed-off-by: Lorenzo Bianconi > --- > arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 73 +++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > index 72e0d9722e07..e3b05280dcb6 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > > / { > interrupt-parent = <&gic>; > @@ -76,6 +77,31 @@ wmcpu_emi: wmcpu-reserved@4fc00000 { > no-map; > reg = <0 0x4fc00000 0 0x00100000>; > }; > + > + wo_emi0: wo-emi0@4fd00000 { > + reg = <0 0x4fd00000 0 0x40000>; > + no-map; > + }; > + > + wo_emi1: wo-emi1@4fd40000 { > + reg = <0 0x4fd40000 0 0x40000>; > + no-map; > + }; > + > + wo_ilm0: wo-ilm0@151e0000 { > + reg = <0 0x151e0000 0 0x8000>; > + no-map; > + }; > + > + wo_ilm1: wo-ilm1@151f0000 { > + reg = <0 0x151f0000 0 0x8000>; > + no-map; > + }; > + > + wo_data: wo-data@4fd80000 { > + reg = <0 0x4fd80000 0 0x240000>; > + no-map; > + }; > }; > > timer { > @@ -226,6 +252,12 @@ ethsys: syscon@15000000 { > reg = <0 0x15000000 0 0x1000>; > #clock-cells = <1>; > #reset-cells = <1>; > + > + ethsysrst: reset-controller { > + compatible = "ti,syscon-reset"; > + #reset-cells = <1>; > + ti,reset-bits = <0x34 4 0x34 4 0x34 4 (ASSERT_SET | DEASSERT_CLEAR | STATUS_SET)>; > + }; > }; > > wed_pcie: wed-pcie@10003000 { > @@ -240,6 +272,10 @@ wed0: wed@15010000 { > reg = <0 0x15010000 0 0x1000>; > interrupt-parent = <&gic>; > interrupts = ; > + memory-region = <&wo_emi0>, <&wo_ilm0>, <&wo_data>; > + mediatek,wo-ccif = <&wo_ccif0>; > + mediatek,wo-dlm = <&wo_dlm0>; > + mediatek,wo-boot = <&wo_boot>; > }; > > wed1: wed@15011000 { > @@ -248,6 +284,43 @@ wed1: wed@15011000 { > reg = <0 0x15011000 0 0x1000>; > interrupt-parent = <&gic>; > interrupts = ; > + memory-region = <&wo_emi1>, <&wo_ilm1>, <&wo_data>; > + mediatek,wo-ccif = <&wo_ccif1>; > + mediatek,wo-dlm = <&wo_dlm1>; > + mediatek,wo-boot = <&wo_boot>; > + }; > + > + wo_ccif0: wo-ccif1@151a5000 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation "1" suffix is for sure not generic. Neither wo-ccif is... unless there is some article on Wikipedia about it? Or maybe generic name is not possible to get, which happens... > + compatible = "mediatek,mt7986-wo-ccif","syscon"; > + reg = <0 0x151a5000 0 0x1000>; > + interrupt-parent = <&gic>; > + interrupts = ; > + }; > + > + wo_ccif1: wo-ccif1@151ad000 { > + compatible = "mediatek,mt7986-wo-ccif","syscon"; > + reg = <0 0x151ad000 0 0x1000>; > + interrupt-parent = <&gic>; > + interrupts = ; > + }; > + > + wo_dlm0: wo-dlm@151e8000 { > + compatible = "mediatek,mt7986-wo-dlm"; > + reg = <0 0x151e8000 0 0x2000>; > + resets = <ðsysrst 0>; > + reset-names = "wocpu_rst"; > + }; > + > + wo_dlm1: wo-dlm@0x151f8000 { > + compatible = "mediatek,mt7986-wo-dlm"; > + reg = <0 0x151f8000 0 0x2000>; > + resets = <ðsysrst 0>; > + reset-names = "wocpu_rst"; > + }; > + > + wo_boot: wo-boot@15194000 { > + compatible = "mediatek,mt7986-wo-boot","syscon"; Missing space. > + reg = <0 0x15194000 0 0x1000>; > }; > > eth: ethernet@15100000 { Best regards, Krzysztof