From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22219EB64D7 for ; Fri, 23 Jun 2023 17:56:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232013AbjFWR4U (ORCPT ); Fri, 23 Jun 2023 13:56:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231209AbjFWR4T (ORCPT ); Fri, 23 Jun 2023 13:56:19 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFF522133 for ; Fri, 23 Jun 2023 10:56:16 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b46cad2fd9so15160371fa.1 for ; Fri, 23 Jun 2023 10:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687542975; x=1690134975; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Dqpntf/6Jri52Dcd19VIMHj5sv//Ye/CfucOhTnMjgU=; b=Yj0UJFhh2g2V49OOG4n5Gda142ZxJ4dg235MQYhivc9d0ZojA3dKvfYOhxBujrF9QI U4BTstcBKpe6uHtOYFF+W25IqepRYllfB/w9tYjAhM7uTCxl9/yr5plD/R6Lit+hFGmT +jEV8l66VXQsCO+UXk+jU+tZl1o3rgu8HvvTzh0eD1n9/uHCn6h3Xn1wx5T3ckK3GCzr eOr0wXf5u3FZdHmY2gYkQsBHuP+2xtzHU6w6ez03wHwx3JeJ5mxSAX2EhBASwKXh6aeD LPewZFDqiWRhO9il6HKDANA87U9FjG7oTr2hV+wrrTHDgRDEYzARs/MDUSDiu7gqileL VEwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687542975; x=1690134975; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dqpntf/6Jri52Dcd19VIMHj5sv//Ye/CfucOhTnMjgU=; b=SjozMTdYSJC3/DHBPjnTN+tOsQPcY7QFpxoaPKg7/HYhaPmca4qNGniqFSde7r0RBk Rj30pMJS0aSl8shNoN3DS6Z5OujS0xrfsgCYuut5PhOtCZnqh1SV0HLYnI08ij33xMT3 6yLKwL5+DxeiqTZSh8CTv+CJcmFrdGf0fdv7ymcVpBNIcIJ/yy3yVWPR+cjV/AGO8fKE g3rX+66qJ6LfSik700zkrfRqBHzILZWsmfLPamIsyyXVlknnj8KoaSEIZcoNICMRUNKr 0MeU4szzrGAqzGOhNQyrYnuEnh7ZYLJXXqLCuRXDXQdwh1kXiZfYA+f6g+nKQsJPkUge 3qiA== X-Gm-Message-State: AC+VfDx/Ht2GLSg/sbLvnSw6MsL5wg+djgXuty18RMH5WLvLs4bv+ROW GSkcfIiWEdwgklPA3rcdhP9P9A== X-Google-Smtp-Source: ACHHUZ5Rb1W0hIZd8jNjDreq5gpwDgx93jadu/h6j65zS2ADyQMD99TR5ZTtPVk0E+fLejpNAIB9BQ== X-Received: by 2002:a05:651c:1022:b0:2b4:636a:67f4 with SMTP id w2-20020a05651c102200b002b4636a67f4mr13763243ljm.20.1687542974817; Fri, 23 Jun 2023 10:56:14 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id w20-20020a1709060a1400b00977eec7b7e8sm6279522ejf.68.2023.06.23.10.56.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 10:56:14 -0700 (PDT) Message-ID: <4fba1603-5741-ec1b-122f-d6a92803f49a@linaro.org> Date: Fri, 23 Jun 2023 19:56:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v5 2/4] dt-bindings: serial: amlogic,meson-uart: Add compatible string for T7 Content-Language: en-US To: tanure@linux.com Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Kevin Hilman , Nick , Artem , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20230623081242.109131-1-tanure@linux.com> <20230623081242.109131-3-tanure@linux.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/06/2023 19:53, Lucas Tanure wrote: > On Fri, Jun 23, 2023 at 9:51 AM Krzysztof Kozlowski > wrote: >> >> On 23/06/2023 10:12, Lucas Tanure wrote: >>> Amlogic T7 SoCs uses the same UART controller as S4 SoCs and G12A. >>> There is no need for an extra compatible line in the driver, but >>> add T7 compatible line for documentation. >>> >>> Signed-off-by: Lucas Tanure >>> --- >>> .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml >>> index 01ec45b3b406..ad970c9ed1c7 100644 >>> --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml >>> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml >>> @@ -50,6 +50,10 @@ properties: >>> items: >>> - const: amlogic,meson-g12a-uart >>> - const: amlogic,meson-gx-uart >>> + - description: UART controller on T7 compatible SoCs >> >> Your description is rather incorrect. This is UART on SoCs compatible >> with S4, not with T7. Otherwise what do you expect to grow later when >> adding more compatible devices? Just drop the description, it's kind of >> obvious when done correctly (but can be misleading if done wrong). >> >> Acked-by: Krzysztof Kozlowski >> > Sorry, but S4 is already added in another way, which accepts just an > S4 compatible string. > But for T7 we need a fallback. > Could you let me know what you're asking here? Redo S4 and add T7? Or > do T7 in another different way that I didn't get? I comment only about the description, so why touching anything else? You did not add here T7 compatible SoCs. You added here S4 compatible SoCs. > Do you want a v6 patch series? If yes, could you be more clear about > how you want it? No need. If you are going to send v6, you can as well drop the description. --- This is an automated instruction, just in case, because many review tags are being ignored. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 Best regards, Krzysztof