devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>,
	LKML <linux-kernel@vger.kernel.org>
Cc: dianders@chromium.org, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v11 5/5] arm64: dts: qcom: sc7280: sort out the "Status" to last property with sc7280-herobrine-audio-rt5682.dtsi
Date: Mon, 7 Nov 2022 11:02:38 +0100	[thread overview]
Message-ID: <4fc177e1-448e-45f4-4a58-d52968536b17@linaro.org> (raw)
In-Reply-To: <20221107173954.v11.5.I4c6d97e6f3cf8cdc691d2d4519883c3018dd4372@changeid>



On 07/11/2022 10:43, Sheng-Liang Pan wrote:
> To keep diffs clean, sort out "Status" to last property.
> 
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> 
> Changes in v11:
> - sort out the "Status" property with sc7280-herobrine-audio-rt5682.dtsi
> 
>   .../dts/qcom/sc7280-herobrine-audio-rt5682.dtsi    | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> index 2dbdeeb29ecec..fc7a659dfe4ae 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -13,14 +13,14 @@ sound: sound {
>   		compatible = "google,sc7280-herobrine";
>   		model = "sc7280-rt5682-max98360a-1mic";
>   
> -		status = "okay";
> -		audio-routing =
> -			"Headphone Jack", "HPOL",
> -			"Headphone Jack", "HPOR";
> +		audio-routing = "Headphone Jack", "HPOL",
> +				"Headphone Jack", "HPOR";
>   
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>   
> +		status = "okay";
> +
>   		dai-link@0 {
>   			link-name = "MAX98360";
>   			reg = <0>;
> @@ -50,8 +50,8 @@ codec {
>   };
>   
>   hp_i2c: &i2c2 {
> -	status = "okay";
>   	clock-frequency = <400000>;
> +	status = "okay";
>   
>   	alc5682: codec@1a {
>   		compatible = "realtek,rt5682s";
> @@ -75,8 +75,6 @@ alc5682: codec@1a {
>   };
>   
>   &lpass_cpu {
> -	status = "okay";
> -
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&mi2s0_data0>, <&mi2s0_data1>, <&mi2s0_mclk>, <&mi2s0_sclk>, <&mi2s0_ws>,
>   			<&mi2s1_data0>, <&mi2s1_sclk>, <&mi2s1_ws>;
> @@ -84,6 +82,8 @@ &lpass_cpu {
>   	#address-cells = <1>;
>   	#size-cells = <0>;
>   
> +	status = "okay";
> +
>   	dai-link@0 {
>   		reg = <MI2S_PRIMARY>;
>   		qcom,playback-sd-lines = <1>;

  reply	other threads:[~2022-11-07 10:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07  9:43 [PATCH v11 0/5] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-11-07  9:43 ` [PATCH v11 1/5] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan
2022-11-07  9:43 ` [PATCH v11 2/5] arm64: dts: qcom: sc7280: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-11-07  9:43 ` [PATCH v11 3/5] arm64: dts: qcom: sc7280: Add touchscreen and touchpad support for evoker Sheng-Liang Pan
2022-11-07  9:43 ` [PATCH v11 4/5] arm64: dts: qcom: sc7280: add sc7280-herobrine-audio-rt5682-3mic3.dtsi " Sheng-Liang Pan
2022-11-07 10:02   ` Konrad Dybcio
2022-11-07 18:15   ` Doug Anderson
2022-11-07  9:43 ` [PATCH v11 5/5] arm64: dts: qcom: sc7280: sort out the "Status" to last property with sc7280-herobrine-audio-rt5682.dtsi Sheng-Liang Pan
2022-11-07 10:02   ` Konrad Dybcio [this message]
2022-11-07 18:12   ` Doug Anderson
2022-11-08  1:27 ` [PATCH v11 0/5] Add LTE SKU for sc7280-evoker family Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fc177e1-448e-45f4-4a58-d52968536b17@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sheng-liang.pan@quanta.corp-partner.google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).