From: Andrew Lunn <andrew@lunn.ch>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Florian Fainelli" <florian.fainelli@broadcom.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] ARM: dts: BCM53573: Fix address of Luxul XAP-1440's Ethernet PHY
Date: Mon, 6 Oct 2025 18:09:45 +0200 [thread overview]
Message-ID: <4fcba9c1-ff83-40b5-b7eb-758fd43ea978@lunn.ch> (raw)
In-Reply-To: <20251002194852.13929-1-zajec5@gmail.com>
On Thu, Oct 02, 2025 at 09:48:52PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Luxul XAP-1440 has BCM54210E PHY at address 25.
>
> Fixes: 44ad82078069 ("ARM: dts: BCM53573: Fix Ethernet info for Luxul devices")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts
> index ac44c745bdf8..a39a021a3910 100644
> --- a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts
> @@ -55,8 +55,8 @@ &gmac0 {
> mdio {
> /delete-node/ switch@1e;
>
> - bcm54210e: ethernet-phy@0 {
> - reg = <0>;
> + bcm54210e: ethernet-phy@25 {
> + reg = <25>;
Does this really not work, or is it relying on the PHY responding to 0
as a broadcast address?
Thanks
Andrew
next prev parent reply other threads:[~2025-10-06 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 19:48 [PATCH] ARM: dts: BCM53573: Fix address of Luxul XAP-1440's Ethernet PHY Rafał Miłecki
2025-10-06 16:09 ` Andrew Lunn [this message]
2025-10-06 20:34 ` Rafał Miłecki
2025-10-13 22:35 ` Florian Fainelli
2025-10-13 22:35 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fcba9c1-ff83-40b5-b7eb-758fd43ea978@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).