From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B076C77B73 for ; Wed, 31 May 2023 08:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235188AbjEaITZ (ORCPT ); Wed, 31 May 2023 04:19:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234854AbjEaITY (ORCPT ); Wed, 31 May 2023 04:19:24 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB466C5 for ; Wed, 31 May 2023 01:19:20 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-96f7377c86aso956593166b.1 for ; Wed, 31 May 2023 01:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685521159; x=1688113159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=17G7fgccZw26IuKEnhcF6apgAkC9GALykdO8V5FR4Zc=; b=jIe6mWyUFq7h8o883sjF4wSXtBDd+bizNgKp2DtJauDCvI5g4VWQcvYx3wxWVLtPmq DwxwtXoa4Pog0Kchm7HKAqaML2QCVDfxTVIcZHUx9Q/nXjFeLO4p5BqWeMEiRSDRuBf3 +EiqsspEnZsz+874OwruO1KbzkrW3v4QC1KeQeCafNQfI7P6qZ9NN8ZfNXxz8LENrZi7 BQOTVODkD57MOtE1Jal69BticPl3JoW1oYtUQc0AFU7i65yvtcqSrP4CKXZubagVbX9V Td+OXZhyQk78D6E96Up6MMmP+hEKuk/bOjpPYjVPN/bb4Zuc1GWL7283Mxxh0pQIGqkK M3+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685521159; x=1688113159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=17G7fgccZw26IuKEnhcF6apgAkC9GALykdO8V5FR4Zc=; b=EN6a1/6QfekFpxZqroMyvwQTTHm3p9YQhZ4dIeo2pkY/WmjQEMdWv+Yju5Z4D9FopA bWhVB0Sx9Eqo4emtag9vtDsYGEGQAlEQlX6ZcxiRlpBIcupE2FH/gdkBojkRajUzJKDQ 5Fs+9qEQ3/CtA2CrRtY9LRyU8Tb4BvafIePkhKPKybh4c7dQ1JyNGv8qDrWdl8iZxJ2L XVt7w3sEjmBK1lINq466c6yQ7Hq7u08COYibhgtsCT5Rh5Et7h4ekHaLYPmJxxOtDr6c i4LgOV8j4+7ScYUbuWd2VUkdpcbbDrj2zJpPybaj99b0Tw+Q/lPQ6srzrluusCIVizuh S/0A== X-Gm-Message-State: AC+VfDw6G2S/IDIV4eNEOaesdYMgErmR8Dfp8xQdkEswH7IO/Rg7Y2Bg iZgpbDIjCVVO65PCzIC3YHnV5Q== X-Google-Smtp-Source: ACHHUZ5ecctufjEICHVJOxqbmGFp4cMb86II1wutT7aAwcq/GT4AF70E5eF22KgMKCTBhO6z0IHKaA== X-Received: by 2002:a17:907:1c84:b0:974:32e:7de9 with SMTP id nb4-20020a1709071c8400b00974032e7de9mr5775337ejc.56.1685521159179; Wed, 31 May 2023 01:19:19 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id a6-20020a170906244600b00965b416585bsm8528500ejb.118.2023.05.31.01.19.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 01:19:18 -0700 (PDT) Message-ID: <4fcbb3b7-ed44-d8e6-a601-e3e957c55ebf@linaro.org> Date: Wed, 31 May 2023 10:19:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 01/15] dt-bindings: PCI: qcom: Fix sc8180x clocks and interrupts Content-Language: en-US To: Vinod Koul , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, Konrad Dybcio , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230530162454.51708-1-vkoul@kernel.org> <20230530162454.51708-2-vkoul@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20230530162454.51708-2-vkoul@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/05/2023 18:24, Vinod Koul wrote: > Commit 45a3ec891370 ("PCI: qcom: Add sc8180x compatible") added sc8180x > compatible and commit 075a9d55932e ("dt-bindings: PCI: qcom: Convert to > YAML") converted the description to yaml > > But there are still some errors specific to sc8180x which this change > attempts to fix. The clocks and resets for sc8180 pcie controller are > different so need to be documented separately I don't get what's the error here to fix. The clocks you list are already there as part of oneOf. > > Signed-off-by: Vinod Koul > --- > .../devicetree/bindings/pci/qcom,pcie.yaml | 29 ++++++++++++++++++- > 1 file changed, 28 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 81971be4e554..40a1f451a3d3 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -476,6 +476,33 @@ allOf: > items: > - const: pci # PCIe core reset > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pcie-sc8180x > + then: > + properties: > + clocks: > + minItems: 8 > + maxItems: 8 > + clock-names: > + items: > + - const: pipe # PIPE clock > + - const: aux # Auxiliary clock > + - const: cfg # Configuration clock > + - const: bus_master # Master AXI clock > + - const: bus_slave # Slave AXI clock > + - const: slave_q2a # Slave Q2A clock > + - const: ref # REFERENCE clock > + - const: tbu # PCIe TBU clock > + resets: > + maxItems: 1 > + reset-names: > + items: > + - const: pci # PCIe core reset > + > - if: > properties: > compatible: > @@ -524,7 +551,6 @@ allOf: > compatible: > contains: > enum: > - - qcom,pcie-sc8180x > - qcom,pcie-sm8150 > - qcom,pcie-sm8250 > then: > @@ -749,6 +775,7 @@ allOf: > contains: > enum: > - qcom,pcie-sa8540p > + - qcom,pcie-sc8180x > - qcom,pcie-sc8280xp > then: > required: Best regards, Krzysztof