From: Marek Vasut <marex@denx.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Andre Werner <andre.werner@systec-electronic.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@denx.de>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Mark Brown <broonie@kernel.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Naresh Solanki <naresh.solanki@9elements.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Rob Herring <robh+dt@kernel.org>,
Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>,
Vincent Tremblay <vincent@vtremblay.dev>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: light: isl76682: Document ISL76682
Date: Sun, 19 Nov 2023 19:08:45 +0100 [thread overview]
Message-ID: <4fe94f10-ff06-417b-a6d5-433bfeeac641@denx.de> (raw)
In-Reply-To: <20231119150756.20a023b5@jic23-huawei>
On 11/19/23 16:07, Jonathan Cameron wrote:
> On Sat, 18 Nov 2023 01:06:09 +0100
> Marek Vasut <marex@denx.de> wrote:
>
>> The ISL76682 is very basic ALS which only supports ALS or IR mode
>> in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any
>> other fancy functionality. Document it as trivial device.
>>
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>
> I'm always a bit in 2 minds about trivial-devices as it doesn't
> include a basic power supply. In this case vdd which I'd prefer
> to see documented even on such a simple device as this.
> Not everyone is going to leave it powered up all the time!
>
> Still I'm not that fussed. Maybe it's worth allowing vdd-supply in
> trivial-devices.yaml?
The hardware I have is powered all the time, so I'd be adding completely
untested code which is no less useless for me (at least right now). Lets
postpone this until there is a need for it, can we ?
I addressed all the other comments in 2/2.
next prev parent reply other threads:[~2023-11-19 18:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 0:06 [PATCH v2 1/2] dt-bindings: iio: light: isl76682: Document ISL76682 Marek Vasut
2023-11-18 0:06 ` [PATCH v2 2/2] iio: light: isl76682: Add ISL76682 driver Marek Vasut
2023-11-19 15:54 ` Jonathan Cameron
2023-11-19 15:07 ` [PATCH v2 1/2] dt-bindings: iio: light: isl76682: Document ISL76682 Jonathan Cameron
2023-11-19 18:08 ` Marek Vasut [this message]
2023-11-20 17:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe94f10-ff06-417b-a6d5-433bfeeac641@denx.de \
--to=marex@denx.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=andre.werner@systec-electronic.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luca.ceresoli@bootlin.com \
--cc=mazziesaccount@gmail.com \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=robh+dt@kernel.org \
--cc=stefan.windfeldt-prytz@axis.com \
--cc=vincent@vtremblay.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).