From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andrei Simion <andrei.simion@microchip.com>,
claudiu.beznea@tuxon.dev, broonie@kernel.org,
lgirdwood@gmail.com, nicolas.ferre@microchip.com,
krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org,
alexandre.belloni@bootlin.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/7] regulator: dt-bindings: microchip,mcp16502: Add voltage input supply documentation
Date: Wed, 14 Aug 2024 11:07:57 +0200 [thread overview]
Message-ID: <4ff0cad2-bbfc-4f8a-bdba-eda2db4fbca8@kernel.org> (raw)
In-Reply-To: <20240812135231.43744-3-andrei.simion@microchip.com>
On 12/08/2024 15:52, Andrei Simion wrote:
> Update the yaml schema with info about input supply phandle for
> each buck and ldo according with the PMIC MCP16502 Datasheet.
>
> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
> ---
> v1 -> v2:
> - added in v2
> ---
> .../regulator/microchip,mcp16502.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml b/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
> index 1aca3646789e..c3e1fc6e260e 100644
> --- a/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
> +++ b/Documentation/devicetree/bindings/regulator/microchip,mcp16502.yaml
> @@ -28,6 +28,21 @@ properties:
> reg:
> maxItems: 1
>
> + lvin-supply:
> + description: Input supply phandle for LDO1 and LDO2
If there is going to be respin, drop phandle. Stating obvious is not
helping - you describe here hardware, not DT.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-14 9:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 13:52 [PATCH v2 0/7] Add input voltage suppliers for PMIC MCP16502 regulators Andrei Simion
2024-08-12 13:52 ` [PATCH v2 1/7] regulator: mcp16502: Add supplier for regulators Andrei Simion
2024-08-12 13:52 ` [PATCH v2 2/7] regulator: dt-bindings: microchip,mcp16502: Add voltage input supply documentation Andrei Simion
2024-08-14 9:07 ` Krzysztof Kozlowski [this message]
2024-08-12 13:52 ` [PATCH v2 3/7] ARM: dts: microchip: at91-sama7g5ek: Add reg_5v to supply PMIC nodes Andrei Simion
2024-08-12 13:52 ` [PATCH v2 4/7] ARM: dts: microchip: at91-sama7g54_curiosity: " Andrei Simion
2024-08-12 13:52 ` [PATCH v2 5/7] ARM: dts: microchip: at91-sama5d2_icp: " Andrei Simion
2024-08-12 13:52 ` [PATCH v2 6/7] ARM: dts: microchip: at91-sama5d27_wlsom1: " Andrei Simion
2024-08-12 13:52 ` [PATCH v2 7/7] ARM: dts: microchip: sama5d29_curiosity: " Andrei Simion
2024-08-12 15:33 ` [PATCH v2 0/7] Add input voltage suppliers for PMIC MCP16502 regulators Rob Herring (Arm)
2024-08-13 15:43 ` (subset) " Mark Brown
2024-08-24 14:15 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ff0cad2-bbfc-4f8a-bdba-eda2db4fbca8@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andrei.simion@microchip.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).