From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>,
mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, hverkuil+cisco@kernel.org
Cc: sakari.ailus@linux.intel.com, bparrot@ti.com,
jai.luthra@ideasonboard.com, dale@farnsworth.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, u-kumar1@ti.com
Subject: Re: [PATCH V3 3/5] media: platform: ti: Switch to EXPORT_SYMBOL_GPL()
Date: Tue, 9 Sep 2025 10:24:11 +0200 [thread overview]
Message-ID: <4ff16bb8-4407-425e-bae7-77ebc53aaec3@kernel.org> (raw)
In-Reply-To: <20250909080718.1381758-4-y-abhilashchandra@ti.com>
On 09/09/2025 10:07, Yemike Abhilash Chandra wrote:
> struct vpdma_dtd *dtd = list->buf.addr;
> dma_addr_t write_desc_addr;
> @@ -597,7 +598,7 @@ void vpdma_update_dma_addr(struct vpdma_data *vpdma,
>
> dump_dtd(dtd);
> }
> -EXPORT_SYMBOL(vpdma_update_dma_addr);
> +EXPORT_SYMBOL_GPL(vpdma_update_dma_addr);
Don't add incorrect code to fix it immediately. Claiming that "you just
revert" is irrelevant here - we are not interested in the revert. Revert
or not, you add new code to the kernel, so that code must be correct.
if you reverted a commit, which was introducing a security bug, your
revert would bring that security bug and you find it okay?
No, NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-09 8:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 8:07 [PATCH V3 0/5] Add support for TI VIP Yemike Abhilash Chandra
2025-09-09 8:07 ` [PATCH V3 1/5] Revert "media: platform: ti: Remove unused vpdma_update_dma_addr" Yemike Abhilash Chandra
2025-09-09 8:21 ` Krzysztof Kozlowski
2025-09-09 8:07 ` [PATCH V3 2/5] media: platform: ti: Add kerneldoc for vpdma_update_dma_addr() Yemike Abhilash Chandra
2025-09-09 8:22 ` Krzysztof Kozlowski
2025-09-09 8:07 ` [PATCH V3 3/5] media: platform: ti: Switch to EXPORT_SYMBOL_GPL() Yemike Abhilash Chandra
2025-09-09 8:24 ` Krzysztof Kozlowski [this message]
2025-09-09 8:07 ` [PATCH V3 4/5] dt-bindings: media: ti: vpe: Add support for Video Input Port Yemike Abhilash Chandra
2025-09-09 8:36 ` Krzysztof Kozlowski
2025-10-13 6:21 ` Yemike Abhilash Chandra
2025-10-13 6:26 ` Krzysztof Kozlowski
2025-09-09 8:07 ` [PATCH V3 5/5] media: ti-vpe: Add the VIP driver Yemike Abhilash Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ff16bb8-4407-425e-bae7-77ebc53aaec3@kernel.org \
--to=krzk@kernel.org \
--cc=bparrot@ti.com \
--cc=conor+dt@kernel.org \
--cc=dale@farnsworth.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=jai.luthra@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=u-kumar1@ti.com \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox