Re: [PATCH V2] mtd: m25p80: Make fast read configurable via DT

Re: [PATCH V2] mtd: m25p80: Make fast read configurable via DT

[Rob Herring]

+devicetree-discuss

On 07/22/2012 08:20 PM, Marek Vasut wrote:
> Add DT property "m25p,fast-read" that signalises the particular
> chip supports "fast read" opcode.
> 
> NOTE: I'm not sure where to document this property, as m25p80 is
>       a simple DT device. Any hints please?
> 
> Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> Cc: Artem Bityutskiy <artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Cc: David Woodhouse <david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mtd/m25p80.txt |   27 ++++++++++++++++++
>  drivers/mtd/devices/m25p80.c                     |   32 +++++++++++++---------
>  2 files changed, 46 insertions(+), 13 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mtd/m25p80.txt
> 
> V2: Add documentation for the DT property. (Thanks Rob Herring for helping!)
>     Supersedes [PATCH 3/3] [RFC] mtd: m25p80: Make fast read configurable via DT
> 
> diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt b/Documentation/devicetree/bindings/mtd/m25p80.txt
> new file mode 100644
> index 0000000..e05d9b8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/m25p80.txt
> @@ -0,0 +1,27 @@
> +* MTD SPI driver for ST M25Pxx (and similar) serial flash chips
> +
> +Required properties:
> +- #address-cells, #size-cells : Must be present if the device has sub-nodes
> +  representing partitions.
> +- compatible : Should be the name of the chip, see the "m25p_ids" table in
> +               drivers/mtd/devices/m25p80.c

Two things wrong with this:

- Bindings are not Linux specific, so the docs should not be based on Linux.
- This doesn't follow the existing user which is "spansion,m25p80"

Rob

> +- reg : Chip-Select number
> +- spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at
> +
> +Optional properties:
> +- m25p,fast-read : Use the "fast read" opcode to read data from the chip instead
> +                   of the usual "read" opcode. This opcode isn not supported by
> +		   all chips and support for it can not be detected at runtime.
> +		   Refer to your chips' datasheet to check if this is supported
> +		   by your chip.
> +
> +Example:
> +
> +	flash: s25sl064p@0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "s25sl064p";
> +		reg = <0>;
> +		spi-max-frequency = <40000000>;
> +		m25p,fast-read;
> +	};
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index d16f75c..c5284cd 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -73,14 +73,6 @@
>  #define	MAX_READY_WAIT_JIFFIES	(40 * HZ)	/* M25P16 specs 40s max chip erase */
>  #define	MAX_CMD_SIZE		5
>  
> -#ifdef CONFIG_M25PXX_USE_FAST_READ
> -#define OPCODE_READ 	OPCODE_FAST_READ
> -#define FAST_READ_DUMMY_BYTE 1
> -#else
> -#define OPCODE_READ 	OPCODE_NORM_READ
> -#define FAST_READ_DUMMY_BYTE 0
> -#endif
> -
>  #define JEDEC_MFR(_jedec_id)	((_jedec_id) >> 16)
>  
>  /****************************************************************************/
> @@ -93,6 +85,7 @@ struct m25p {
>  	u16			addr_width;
>  	u8			erase_opcode;
>  	u8			*command;
> +	bool			fast_read;
>  };
>  
>  static inline struct m25p *mtd_to_m25p(struct mtd_info *mtd)
> @@ -342,6 +335,7 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len,
>  	struct m25p *flash = mtd_to_m25p(mtd);
>  	struct spi_transfer t[2];
>  	struct spi_message m;
> +	uint8_t opcode;
>  
>  	pr_debug("%s: %s from 0x%08x, len %zd\n", dev_name(&flash->spi->dev),
>  			__func__, (u32)from, len);
> @@ -354,7 +348,7 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len,
>  	 * Should add 1 byte DUMMY_BYTE.
>  	 */
>  	t[0].tx_buf = flash->command;
> -	t[0].len = m25p_cmdsz(flash) + FAST_READ_DUMMY_BYTE;
> +	t[0].len = m25p_cmdsz(flash) + (flash->fast_read ? 1 : 0);
>  	spi_message_add_tail(&t[0], &m);
>  
>  	t[1].rx_buf = buf;
> @@ -376,12 +370,14 @@ static int m25p80_read(struct mtd_info *mtd, loff_t from, size_t len,
>  	 */
>  
>  	/* Set up the write data buffer. */
> -	flash->command[0] = OPCODE_READ;
> +	opcode = flash->fast_read ? OPCODE_FAST_READ : OPCODE_NORM_READ;
> +	flash->command[0] = opcode;
>  	m25p_addr2cmd(flash, from, flash->command);
>  
>  	spi_sync(flash->spi, &m);
>  
> -	*retlen = m.actual_length - m25p_cmdsz(flash) - FAST_READ_DUMMY_BYTE;
> +	*retlen = m.actual_length - m25p_cmdsz(flash) -
> +			(flash->fast_read ? 1 : 0);
>  
>  	mutex_unlock(&flash->lock);
>  
> @@ -804,9 +800,10 @@ static int __devinit m25p_probe(struct spi_device *spi)
>  	struct flash_info		*info;
>  	unsigned			i;
>  	struct mtd_part_parser_data	ppdata;
> +	struct device_node		*np = spi->dev.of_node;
>  
>  #ifdef CONFIG_MTD_OF_PARTS
> -	if (!of_device_is_available(spi->dev.of_node))
> +	if (!of_device_is_available(np))
>  		return -ENODEV;
>  #endif
>  
> @@ -858,7 +855,8 @@ static int __devinit m25p_probe(struct spi_device *spi)
>  	flash = kzalloc(sizeof *flash, GFP_KERNEL);
>  	if (!flash)
>  		return -ENOMEM;
> -	flash->command = kmalloc(MAX_CMD_SIZE + FAST_READ_DUMMY_BYTE, GFP_KERNEL);
> +	flash->command = kmalloc(MAX_CMD_SIZE + (flash->fast_read ? 1 : 0),
> +					GFP_KERNEL);
>  	if (!flash->command) {
>  		kfree(flash);
>  		return -ENOMEM;
> @@ -915,6 +913,14 @@ static int __devinit m25p_probe(struct spi_device *spi)
>  	flash->page_size = info->page_size;
>  	flash->mtd.writebufsize = flash->page_size;
>  
> +	flash->fast_read = false;
> +	if (np && of_find_property(np, "m25p,fast-read", NULL))
> +		flash->fast_read = true;
> +
> +#ifdef CONFIG_M25PXX_USE_FAST_READ
> +	flash->fast_read = true;
> +#endif
> +
>  	if (info->addr_width)
>  		flash->addr_width = info->addr_width;
>  	else {
> 

Re: [PATCH V2] mtd: m25p80: Make fast read configurable via DT

[Marek Vasut]

Dear Rob Herring,

> +devicetree-discuss
> 
> On 07/22/2012 08:20 PM, Marek Vasut wrote:
> > Add DT property "m25p,fast-read" that signalises the particular
> > chip supports "fast read" opcode.
> > 
> > NOTE: I'm not sure where to document this property, as m25p80 is
> > 
> >       a simple DT device. Any hints please?
> > 
> > Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> > Cc: Artem Bityutskiy <artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Cc: David Woodhouse <david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> > 
> >  Documentation/devicetree/bindings/mtd/m25p80.txt |   27
> >  ++++++++++++++++++ drivers/mtd/devices/m25p80.c                     |  
> >  32 +++++++++++++--------- 2 files changed, 46 insertions(+), 13
> >  deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/mtd/m25p80.txt
> > 
> > V2: Add documentation for the DT property. (Thanks Rob Herring for
> > helping!)
> > 
> >     Supersedes [PATCH 3/3] [RFC] mtd: m25p80: Make fast read configurable
> >     via DT
> > 
> > diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt
> > b/Documentation/devicetree/bindings/mtd/m25p80.txt new file mode 100644
> > index 0000000..e05d9b8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/m25p80.txt
> > @@ -0,0 +1,27 @@
> > +* MTD SPI driver for ST M25Pxx (and similar) serial flash chips
> > +
> > +Required properties:
> > +- #address-cells, #size-cells : Must be present if the device has
> > sub-nodes +  representing partitions.
> > +- compatible : Should be the name of the chip, see the "m25p_ids" table
> > in +               drivers/mtd/devices/m25p80.c
> 
> Two things wrong with this:

Damn, I just sent a V3 a minute ago. Please ignore that V3 then, since V4 will 
come of course, sorry about the noise. Let's discuss this properly.

> - Bindings are not Linux specific, so the docs should not be based on Linux.

Correct. Can you please advise how to formulate the "compatible" property then?

> - This doesn't follow the existing user which is "spansion,m25p80"

It doesn't, but the driver does support many other chips as well. I wasn't quite 
sure how to go about that either. Any help would be appreciated, I gotta admit 
I'm still a bit lost in all the devicetree stuff.

> Rob
[...]

Re: [PATCH V2] mtd: m25p80: Make fast read configurable via DT

[Marek Vasut]

Dear Rob Herring,

> > +devicetree-discuss
> > 
> > On 07/22/2012 08:20 PM, Marek Vasut wrote:
> > > Add DT property "m25p,fast-read" that signalises the particular
> > > chip supports "fast read" opcode.
> > > 
> > > NOTE: I'm not sure where to document this property, as m25p80 is
> > > 
> > >       a simple DT device. Any hints please?
> > > 
> > > Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> > > Cc: Artem Bityutskiy <artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > > Cc: David Woodhouse <david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > ---
> > > 
> > >  Documentation/devicetree/bindings/mtd/m25p80.txt |   27
> > >  ++++++++++++++++++ drivers/mtd/devices/m25p80.c                     |
> > >  32 +++++++++++++--------- 2 files changed, 46 insertions(+), 13
> > >  deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/mtd/m25p80.txt
> > > 
> > > V2: Add documentation for the DT property. (Thanks Rob Herring for
> > > helping!)
> > > 
> > >     Supersedes [PATCH 3/3] [RFC] mtd: m25p80: Make fast read
> > >     configurable via DT
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt
> > > b/Documentation/devicetree/bindings/mtd/m25p80.txt new file mode 100644
> > > index 0000000..e05d9b8
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mtd/m25p80.txt
> > > @@ -0,0 +1,27 @@
> > > +* MTD SPI driver for ST M25Pxx (and similar) serial flash chips
> > > +
> > > +Required properties:
> > > +- #address-cells, #size-cells : Must be present if the device has
> > > sub-nodes +  representing partitions.
> > > +- compatible : Should be the name of the chip, see the "m25p_ids"
> > > table in +               drivers/mtd/devices/m25p80.c
> > 
> > Two things wrong with this:
> Damn, I just sent a V3 a minute ago. Please ignore that V3 then, since V4
> will come of course, sorry about the noise. Let's discuss this properly.
> 
> > - Bindings are not Linux specific, so the docs should not be based on
> > Linux.
> 
> Correct. Can you please advise how to formulate the "compatible" property
> then?
> 
> > - This doesn't follow the existing user which is "spansion,m25p80"
> 
> It doesn't, but the driver does support many other chips as well. I wasn't
> quite sure how to go about that either. Any help would be appreciated, I
> gotta admit I'm still a bit lost in all the devicetree stuff.
> 
> > Rob
> 
> [...]

Bump?

Best regards,
Marek Vasut