From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data Date: Thu, 26 Jul 2012 10:36:55 +0200 Message-ID: <501101A7.2030503@gmail.com> References: <1343219012-19472-1-git-send-email-anilkumar@ti.com> <1343219012-19472-2-git-send-email-anilkumar@ti.com> <500FE9FC.7070303@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <500FE9FC.7070303@mvista.com> Sender: linux-omap-owner@vger.kernel.org To: Sergei Shtylyov Cc: AnilKumar Ch , tony@atomide.com, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca, mkl@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, wg@grandegger.com List-Id: devicetree@vger.kernel.org On 25.07.2012 14:43, Sergei Shtylyov wrote: > Hello. > > On 25-07-2012 16:23, AnilKumar Ch wrote: > >> Add Bosch D_CAN controller device tree data to AM33XX dtsi file >> by adding d_can device node with all the necessary parameters. > >> Signed-off-by: AnilKumar Ch >> --- >> arch/arm/boot/dts/am33xx.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) > >> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >> index 9b974dc..2db2ffb 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi >> @@ -163,5 +163,10 @@ >> #size-cells = <0>; >> ti,hwmods = "i2c3"; >> }; >> + >> + dcan1: d_can@481D0000 { > > Address postfix in the node name and no "reg" property? This still works due to the hwmod mappings OMAP relies on. I would still put it there, so the switch to real DT definitions will be less painful. Daniel