* [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board
@ 2025-06-02 14:06 Frank Li
2025-06-02 15:34 ` Vladimir Zapolskiy
2025-06-02 16:17 ` Krzysztof Kozlowski
0 siblings, 2 replies; 9+ messages in thread
From: Frank Li @ 2025-06-02 14:06 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Alexander Stein, Marek Vasut, Peng Fan, Michael Walle,
Fabio Estevam, Markus Niebel, Frieder Schrempf, Francesco Dolcini,
Max Merchel, Tim Harvey,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
warnings:
arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../devicetree/bindings/arm/fsl.yaml | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index d3b5e6923e416..75e46ffe9ba8c 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1711,6 +1711,29 @@ properties:
- traverse,ten64 # Ten64 Networking Appliance / Board
- const: fsl,ls1088a
+ - description: lpc based Boards
+ items:
+ - enum:
+ - ea,lpc4357-developers-kit
+ - ciaa,lpc4337
+ - enum:
+ - nxp,lpc4337
+ - nxp,lpc4357
+ - const: nxp,lpc4350
+
+ - description: lpc based Boards
+ items:
+ - enum:
+ - hitex,lpc4350-eval-board
+ - const: nxp,lpc4350
+
+
+ - description: lpc based board
+ items:
+ - enum:
+ - myir,myd-lpc4357
+ - const: nxp,lpc4357
+
additionalProperties: true
...
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board
2025-06-02 14:06 [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board Frank Li
@ 2025-06-02 15:34 ` Vladimir Zapolskiy
2025-06-02 16:04 ` Frank Li
2025-06-02 16:17 ` Krzysztof Kozlowski
1 sibling, 1 reply; 9+ messages in thread
From: Vladimir Zapolskiy @ 2025-06-02 15:34 UTC (permalink / raw)
To: Frank Li, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Alexander Stein, Marek Vasut, Peng Fan, Michael Walle,
Fabio Estevam, Markus Niebel, Frieder Schrempf, Francesco Dolcini,
Max Merchel, Tim Harvey,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 6/2/25 17:06, Frank Li wrote:
> Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
> warnings:
> arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../devicetree/bindings/arm/fsl.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
I prefer to see NXP SoC powered boards under Documentation/devicetree/bindings/arm/nxp/
LPC18XX/LPC43XX SoCs are not Freescale.
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board
2025-06-02 15:34 ` Vladimir Zapolskiy
@ 2025-06-02 16:04 ` Frank Li
2025-06-02 17:17 ` Vladimir Zapolskiy
0 siblings, 1 reply; 9+ messages in thread
From: Frank Li @ 2025-06-02 16:04 UTC (permalink / raw)
To: Vladimir Zapolskiy
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Alexander Stein, Marek Vasut, Peng Fan, Michael Walle,
Fabio Estevam, Markus Niebel, Frieder Schrempf, Francesco Dolcini,
Max Merchel, Tim Harvey,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Mon, Jun 02, 2025 at 06:34:14PM +0300, Vladimir Zapolskiy wrote:
> On 6/2/25 17:06, Frank Li wrote:
> > Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
> > warnings:
> > arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > .../devicetree/bindings/arm/fsl.yaml | 23 +++++++++++++++++++
> > 1 file changed, 23 insertions(+)
>
> I prefer to see NXP SoC powered boards under Documentation/devicetree/bindings/arm/nxp/
>
> LPC18XX/LPC43XX SoCs are not Freescale.
Generally, we don't distingiush that, new s32g chip also in this files.
All nxp/fsl was maintained by one person and everyone know these are one
company now.
Frank
>
> --
> Best wishes,
> Vladimir
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board
2025-06-02 16:04 ` Frank Li
@ 2025-06-02 17:17 ` Vladimir Zapolskiy
2025-06-02 22:09 ` Frank Li
0 siblings, 1 reply; 9+ messages in thread
From: Vladimir Zapolskiy @ 2025-06-02 17:17 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Alexander Stein, Marek Vasut, Peng Fan, Michael Walle,
Fabio Estevam, Markus Niebel, Frieder Schrempf, Francesco Dolcini,
Max Merchel, Tim Harvey,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On 6/2/25 19:04, Frank Li wrote:
> On Mon, Jun 02, 2025 at 06:34:14PM +0300, Vladimir Zapolskiy wrote:
>> On 6/2/25 17:06, Frank Li wrote:
>>> Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
>>> warnings:
>>> arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
>>>
>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>> ---
>>> .../devicetree/bindings/arm/fsl.yaml | 23 +++++++++++++++++++
>>> 1 file changed, 23 insertions(+)
>>
>> I prefer to see NXP SoC powered boards under Documentation/devicetree/bindings/arm/nxp/
>>
>> LPC18XX/LPC43XX SoCs are not Freescale.
>
> Generally, we don't distingiush that, new s32g chip also in this files.
> All nxp/fsl was maintained by one person and everyone know these are one
> company now.
Well, my concern is actually not about the companies, but these two SoC
families are totally different, the peripherals or core controllers are
all different, it makes little sense to mix them up.
I won't raise any questions or insist on the correctness of i.MX placement
under arm/nxp or arm/freescale, but NXP LPC32xx and NXP LPC18xx/LPC43xx dt
bindings shall be put under arm/nxp for certain.
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board
2025-06-02 17:17 ` Vladimir Zapolskiy
@ 2025-06-02 22:09 ` Frank Li
2025-06-06 0:00 ` Rob Herring
0 siblings, 1 reply; 9+ messages in thread
From: Frank Li @ 2025-06-02 22:09 UTC (permalink / raw)
To: Vladimir Zapolskiy
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Alexander Stein, Marek Vasut, Peng Fan, Michael Walle,
Fabio Estevam, Markus Niebel, Frieder Schrempf, Francesco Dolcini,
Max Merchel, Tim Harvey,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Mon, Jun 02, 2025 at 08:17:06PM +0300, Vladimir Zapolskiy wrote:
> On 6/2/25 19:04, Frank Li wrote:
> > On Mon, Jun 02, 2025 at 06:34:14PM +0300, Vladimir Zapolskiy wrote:
> > > On 6/2/25 17:06, Frank Li wrote:
> > > > Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
> > > > warnings:
> > > > arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > > .../devicetree/bindings/arm/fsl.yaml | 23 +++++++++++++++++++
> > > > 1 file changed, 23 insertions(+)
> > >
> > > I prefer to see NXP SoC powered boards under Documentation/devicetree/bindings/arm/nxp/
> > >
> > > LPC18XX/LPC43XX SoCs are not Freescale.
> >
> > Generally, we don't distingiush that, new s32g chip also in this files.
> > All nxp/fsl was maintained by one person and everyone know these are one
> > company now.
>
> Well, my concern is actually not about the companies, but these two SoC
> families are totally different, the peripherals or core controllers are
> all different, it makes little sense to mix them up.
This just collect board level compatible string, like trivial-devices.yaml,
which collect variance devices.
Shawn:
Do you like create a nxp.yaml for LPC18xx/LPC43xx boards?
Frank
>
> I won't raise any questions or insist on the correctness of i.MX placement
> under arm/nxp or arm/freescale, but NXP LPC32xx and NXP LPC18xx/LPC43xx dt
> bindings shall be put under arm/nxp for certain.
>
> --
> Best wishes,
> Vladimir
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board
2025-06-02 22:09 ` Frank Li
@ 2025-06-06 0:00 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2025-06-06 0:00 UTC (permalink / raw)
To: Frank Li
Cc: Vladimir Zapolskiy, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Alexander Stein, Marek Vasut, Peng Fan, Michael Walle,
Fabio Estevam, Markus Niebel, Frieder Schrempf, Francesco Dolcini,
Max Merchel, Tim Harvey,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Mon, Jun 02, 2025 at 06:09:20PM -0400, Frank Li wrote:
> On Mon, Jun 02, 2025 at 08:17:06PM +0300, Vladimir Zapolskiy wrote:
> > On 6/2/25 19:04, Frank Li wrote:
> > > On Mon, Jun 02, 2025 at 06:34:14PM +0300, Vladimir Zapolskiy wrote:
> > > > On 6/2/25 17:06, Frank Li wrote:
> > > > > Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
> > > > > warnings:
> > > > > arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
> > > > >
> > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > > ---
> > > > > .../devicetree/bindings/arm/fsl.yaml | 23 +++++++++++++++++++
> > > > > 1 file changed, 23 insertions(+)
> > > >
> > > > I prefer to see NXP SoC powered boards under Documentation/devicetree/bindings/arm/nxp/
> > > >
> > > > LPC18XX/LPC43XX SoCs are not Freescale.
> > >
> > > Generally, we don't distingiush that, new s32g chip also in this files.
> > > All nxp/fsl was maintained by one person and everyone know these are one
> > > company now.
> >
> > Well, my concern is actually not about the companies, but these two SoC
> > families are totally different, the peripherals or core controllers are
> > all different, it makes little sense to mix them up.
>
> This just collect board level compatible string, like trivial-devices.yaml,
> which collect variance devices.
>
> Shawn:
> Do you like create a nxp.yaml for LPC18xx/LPC43xx boards?
Please do. We have things like PXA2xx under intel, but PXA9xx/MNP under
marvell as that's the companies that created the lines and there's no
overlap. In the end, aligning the lineage is more important than
companies.
We already have nxp/lpc32xx.yaml. This should probably be merged with
that?
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board
2025-06-02 14:06 [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board Frank Li
2025-06-02 15:34 ` Vladimir Zapolskiy
@ 2025-06-02 16:17 ` Krzysztof Kozlowski
2025-06-02 22:19 ` Frank Li
1 sibling, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-02 16:17 UTC (permalink / raw)
To: Frank Li, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Alexander Stein, Marek Vasut, Peng Fan, Michael Walle,
Fabio Estevam, Markus Niebel, Frieder Schrempf, Francesco Dolcini,
Max Merchel, Tim Harvey,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 02/06/2025 16:06, Frank Li wrote:
> Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
typo: legacy
> warnings:
> arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../devicetree/bindings/arm/fsl.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index d3b5e6923e416..75e46ffe9ba8c 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1711,6 +1711,29 @@ properties:
> - traverse,ten64 # Ten64 Networking Appliance / Board
> - const: fsl,ls1088a
>
> + - description: lpc based Boards
> + items:
> + - enum:
> + - ea,lpc4357-developers-kit
> + - ciaa,lpc4337
> + - enum:
> + - nxp,lpc4337
> + - nxp,lpc4357
This feels wrong. Why 4337-based board is compatible with 4357 SoC? If
this was intentional either DTS is wrong or commit msg needs explanation.
> + - const: nxp,lpc4350
> +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board
2025-06-02 16:17 ` Krzysztof Kozlowski
@ 2025-06-02 22:19 ` Frank Li
2025-06-03 6:49 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Frank Li @ 2025-06-02 22:19 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Alexander Stein, Marek Vasut, Peng Fan, Michael Walle,
Fabio Estevam, Markus Niebel, Frieder Schrempf, Francesco Dolcini,
Max Merchel, Tim Harvey,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Mon, Jun 02, 2025 at 06:17:49PM +0200, Krzysztof Kozlowski wrote:
> On 02/06/2025 16:06, Frank Li wrote:
> > Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
>
> typo: legacy
>
> > warnings:
> > arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
>
>
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > .../devicetree/bindings/arm/fsl.yaml | 23 +++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index d3b5e6923e416..75e46ffe9ba8c 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -1711,6 +1711,29 @@ properties:
> > - traverse,ten64 # Ten64 Networking Appliance / Board
> > - const: fsl,ls1088a
> >
> > + - description: lpc based Boards
> > + items:
> > + - enum:
> > + - ea,lpc4357-developers-kit
> > + - ciaa,lpc4337
> > + - enum:
> > + - nxp,lpc4337
> > + - nxp,lpc4357
>
> This feels wrong. Why 4337-based board is compatible with 4357 SoC? If
> this was intentional either DTS is wrong or commit msg needs explanation.
I think it is that legacy board dts mess up. I am okay to fix boards's dts.
but I have not hardware to test such changes. There are some risk to toggle
such old boards, such as the uboot may check these comaptible string to do
some fixup. Anyways, these boards is too old.
Do you think it worth to fix dts by take some little risk.
Frank
>
> > + - const: nxp,lpc4350
> > +
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board
2025-06-02 22:19 ` Frank Li
@ 2025-06-03 6:49 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-03 6:49 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Alexander Stein, Marek Vasut, Peng Fan, Michael Walle,
Fabio Estevam, Markus Niebel, Frieder Schrempf, Francesco Dolcini,
Max Merchel, Tim Harvey,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On 03/06/2025 00:19, Frank Li wrote:
> On Mon, Jun 02, 2025 at 06:17:49PM +0200, Krzysztof Kozlowski wrote:
>> On 02/06/2025 16:06, Frank Li wrote:
>>> Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
>>
>> typo: legacy
>>
>>> warnings:
>>> arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
>>
>>
>>>
>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>> ---
>>> .../devicetree/bindings/arm/fsl.yaml | 23 +++++++++++++++++++
>>> 1 file changed, 23 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> index d3b5e6923e416..75e46ffe9ba8c 100644
>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> @@ -1711,6 +1711,29 @@ properties:
>>> - traverse,ten64 # Ten64 Networking Appliance / Board
>>> - const: fsl,ls1088a
>>>
>>> + - description: lpc based Boards
>>> + items:
>>> + - enum:
>>> + - ea,lpc4357-developers-kit
>>> + - ciaa,lpc4337
>>> + - enum:
>>> + - nxp,lpc4337
>>> + - nxp,lpc4357
>>
>> This feels wrong. Why 4337-based board is compatible with 4357 SoC? If
>> this was intentional either DTS is wrong or commit msg needs explanation.
>
> I think it is that legacy board dts mess up. I am okay to fix boards's dts.
> but I have not hardware to test such changes. There are some risk to toggle
> such old boards, such as the uboot may check these comaptible string to do
> some fixup. Anyways, these boards is too old.
>
> Do you think it worth to fix dts by take some little risk.
Well, I do not see ea,lpc4357-developers-kit with 4337 fallback, so I
don't understand what existing DTS. If you mean out of tree DTS, it's
their problem.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-06-06 0:00 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-02 14:06 [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board Frank Li
2025-06-02 15:34 ` Vladimir Zapolskiy
2025-06-02 16:04 ` Frank Li
2025-06-02 17:17 ` Vladimir Zapolskiy
2025-06-02 22:09 ` Frank Li
2025-06-06 0:00 ` Rob Herring
2025-06-02 16:17 ` Krzysztof Kozlowski
2025-06-02 22:19 ` Frank Li
2025-06-03 6:49 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).