From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH v3 0/3] Add DT support to C_CAN/D_CAN controller
Date: Thu, 02 Aug 2012 13:13:04 +0200
Message-ID: <501A60C0.1040504@pengutronix.de>
References: <1343905339-4642-1-git-send-email-anilkumar@ti.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigC464E2F8B680053B5837DFFD"
Return-path: <linux-can-owner@vger.kernel.org>
In-Reply-To: <1343905339-4642-1-git-send-email-anilkumar@ti.com>
Sender: linux-can-owner@vger.kernel.org
To: AnilKumar Ch <anilkumar@ti.com>
Cc: wg@grandegger.com, linux-can@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca, anantgole@ti.com, nsekhar@ti.com
List-Id: devicetree@vger.kernel.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigC464E2F8B680053B5837DFFD
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 08/02/2012 01:02 PM, AnilKumar Ch wrote:
> This patch series adds the device tree support and Runtime PM support
> to C_CAN/D_CAN controller.
>=20
> These patches have been tested on AM335x EVM using some additional
> patches to add device tree data to EVM dts files and to initialize
> D_CAN RAM. D_CAN raminit is controlled from control module register.
> This patch will be submitted once control module MFD driver support
> is added.
>=20
> These patches are based on linx-can-next tree.
>=20
> Due to lack of hardware I am not able to test c_can functionality.
> I appreciate if anyone can test c_can functionality with this patch
> series.
>=20
> Changes from v2:
> 	- Incorporated Marcs on v2
> 	  * Fix compilation errors in pci due to device name changes
> 	  in v2 by adding new patch.
>=20
> Changes from v1:
> 	- Separated 4 patches into CAN driver specific and device
> 	  tree data addition specific.
> 	- Incorporated Marc's comments on v1
> 	  * Modified c_can_dev_id enum to handle both devtype and
> 	    platform device id index.
> 	  * Removed "legacy bosch,c_can_platform" from DT bindings
>=20
> AnilKumar Ch (3):
>   can: c_can: Add device tree support to Bosch C_CAN/D_CAN controller
>   can: c_can: Modify c_can device names in c_can_pci driver

You break bisectability here. After patch 1 the pci driver will not
compile anymore. I suggest to do the renaming of enum c_can_dev_id and
all it's users in patch 1.

Marc
>   can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller
>=20
>  .../devicetree/bindings/net/can/c_can.txt          |   37 +++++++++++
>  drivers/net/can/c_can/c_can.h                      |    5 +-
>  drivers/net/can/c_can/c_can_pci.c                  |    6 +-
>  drivers/net/can/c_can/c_can_platform.c             |   65 ++++++++++++=
+++-----
>  4 files changed, 91 insertions(+), 22 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/can/c_can.txt=

>=20


--=20
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


--------------enigC464E2F8B680053B5837DFFD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlAaYMMACgkQjTAFq1RaXHPnqwCfVB9xb7+WBQVt1e891AacC0DR
ny4AniXVpODu5rsfEjhhVm8sOGk0d6/N
=5Fos
-----END PGP SIGNATURE-----

--------------enigC464E2F8B680053B5837DFFD--