From: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: "AnilKumar, Chimata" <anilkumar-l0cyMroinI0@public.gmane.org>
Cc: "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"Nori, Sekhar" <nsekhar-l0cyMroinI0@public.gmane.org>,
"linux-can-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-can-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Gole, Anant" <anantgole-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH v3 0/3] Add DT support to C_CAN/D_CAN controller
Date: Thu, 02 Aug 2012 13:45:26 +0200 [thread overview]
Message-ID: <501A6856.9010706@pengutronix.de> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA081FB-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1383 bytes --]
On 08/02/2012 01:39 PM, AnilKumar, Chimata wrote:
[...]
>>>>> AnilKumar Ch (3):
>>>>> can: c_can: Add device tree support to Bosch C_CAN/D_CAN controller
>>>>> can: c_can: Modify c_can device names in c_can_pci driver
>>>>
>>>> You break bisectability here. After patch 1 the pci driver will not
>>>> compile anymore. I suggest to do the renaming of enum c_can_dev_id and
>>>> all it's users in patch 1.
>>>>
>>>
>>> I will merge patch 1 and 2 and submit v4.
>>
>> But changing the pci driver has nothing to do with the subject ("Add
>> device tree support to Bosch C_CAN/D_CAN controller").
>>
>> It's considered bad practise to do so.
>>
>
> In that case I will change the patch 1 according to "C_CAN_PLTFORM_DEVTYPE"
> and flag name changes to BOSCH_* will be in patch 2. So that we can get rid
> of these two problems.
I'm not sure if I understand you correctly. Please first rename the
constants, then add device tree support.
It doesn't make any sense to first introduce DT support and then patch
parts of the DT that have been added in the previous patch.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2012-08-02 11:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 11:02 [PATCH v3 0/3] Add DT support to C_CAN/D_CAN controller AnilKumar Ch
2012-08-02 11:02 ` [PATCH v3 1/3] can: c_can: Add device tree support to Bosch " AnilKumar Ch
2012-08-02 11:33 ` Arnd Bergmann
2012-08-02 12:01 ` AnilKumar, Chimata
[not found] ` <1343905339-4642-1-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org>
2012-08-02 11:02 ` [PATCH v3 2/3] can: c_can: Modify c_can device names in c_can_pci driver AnilKumar Ch
2012-08-02 11:02 ` [PATCH v3 3/3] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller AnilKumar Ch
2012-08-02 11:13 ` [PATCH v3 0/3] Add DT support to " Marc Kleine-Budde
[not found] ` <501A60C0.1040504-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-08-02 11:21 ` AnilKumar, Chimata
2012-08-02 11:23 ` Marc Kleine-Budde
[not found] ` <501A633A.5000100-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-08-02 11:39 ` AnilKumar, Chimata
[not found] ` <331ABD5ECB02734CA317220B2BBEABC13EA081FB-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2012-08-02 11:45 ` Marc Kleine-Budde [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-02 13:13 AnilKumar Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501A6856.9010706@pengutronix.de \
--to=mkl-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=anantgole-l0cyMroinI0@public.gmane.org \
--cc=anilkumar-l0cyMroinI0@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-can-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).