[PATCH v2 0/2] Add D_CAN device tree data to AM335x-EVM

[PATCH v2 0/2] Add D_CAN device tree data to AM335x-EVM

[AnilKumar Ch]

Thid patch series adds device tree data to AM335x-EVM file and
adds pinmux settings required to configure two of the AM335x EVM
pins to D_CAN TX/RX pins.

Changes from v1:
	- These two patches separated from c_can DT support
	  patch series.

AnilKumar Ch (2):
  arm/dts: AM33XX: Add D_CAN device tree data
  arm/dts: AM33XX: Configure pinmuxs for D_CAN1 on AM335x-EVM

 arch/arm/boot/dts/am335x-evm.dts |   13 +++++++++++++
 arch/arm/boot/dts/am33xx.dtsi    |    5 +++++
 2 files changed, 18 insertions(+)

-- 
1.7.9.5

[PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[AnilKumar Ch]

Add Bosch D_CAN controller device tree data to AM33XX dtsi file
by adding d_can device node with all the necessary parameters.

Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
 arch/arm/boot/dts/am33xx.dtsi |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 9b974dc..2db2ffb 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -163,5 +163,10 @@
 			#size-cells = <0>;
 			ti,hwmods = "i2c3";
 		};
+
+		dcan1: d_can@481D0000 {
+			compatible = "bosch,d_can";
+			ti,hwmods = "d_can1";
+		};
 	};
 };
-- 
1.7.9.5

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[Sergei Shtylyov]

Hello.

On 25-07-2012 16:23, AnilKumar Ch wrote:

> Add Bosch D_CAN controller device tree data to AM33XX dtsi file
> by adding d_can device node with all the necessary parameters.

> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
>   arch/arm/boot/dts/am33xx.dtsi |    5 +++++
>   1 file changed, 5 insertions(+)

> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 9b974dc..2db2ffb 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -163,5 +163,10 @@
>   			#size-cells = <0>;
>   			ti,hwmods = "i2c3";
>   		};
> +
> +		dcan1: d_can@481D0000 {

    Address postfix in the node name and no "reg" property?

> +			compatible = "bosch,d_can";
> +			ti,hwmods = "d_can1";
> +		};

WBR, Sergei

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[Daniel Mack]

On 25.07.2012 14:43, Sergei Shtylyov wrote:
> Hello.
> 
> On 25-07-2012 16:23, AnilKumar Ch wrote:
> 
>> Add Bosch D_CAN controller device tree data to AM33XX dtsi file
>> by adding d_can device node with all the necessary parameters.
> 
>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>> ---
>>   arch/arm/boot/dts/am33xx.dtsi |    5 +++++
>>   1 file changed, 5 insertions(+)
> 
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index 9b974dc..2db2ffb 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -163,5 +163,10 @@
>>   			#size-cells = <0>;
>>   			ti,hwmods = "i2c3";
>>   		};
>> +
>> +		dcan1: d_can@481D0000 {
> 
>     Address postfix in the node name and no "reg" property?

This still works due to the hwmod mappings OMAP relies on. I would still
put it there, so the switch to real DT definitions will be less painful.


Daniel

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[Sergei Shtylyov]

Hello.

On 26-07-2012 12:36, Daniel Mack wrote:

>>> Add Bosch D_CAN controller device tree data to AM33XX dtsi file
>>> by adding d_can device node with all the necessary parameters.

>>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>>> ---
>>>    arch/arm/boot/dts/am33xx.dtsi |    5 +++++
>>>    1 file changed, 5 insertions(+)

>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>>> index 9b974dc..2db2ffb 100644
>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>> @@ -163,5 +163,10 @@
>>>    			#size-cells = <0>;
>>>    			ti,hwmods = "i2c3";
>>>    		};
>>> +
>>> +		dcan1: d_can@481D0000 {
>>
>>      Address postfix in the node name and no "reg" property?

> This still works due to the hwmod mappings OMAP relies on.

    I.e. the "reg" property is populated in runtime?

> I would still
> put it there, so the switch to real DT definitions will be less painful.

    How it helps anything?

> Daniel

WBR, Sergei

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[Vaibhav Hiremath]

On 7/26/2012 6:34 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 26-07-2012 12:36, Daniel Mack wrote:
> 
>>>> Add Bosch D_CAN controller device tree data to AM33XX dtsi file
>>>> by adding d_can device node with all the necessary parameters.
> 
>>>> Signed-off-by: AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org>
>>>> ---
>>>>    arch/arm/boot/dts/am33xx.dtsi |    5 +++++
>>>>    1 file changed, 5 insertions(+)
> 
>>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>>>> index 9b974dc..2db2ffb 100644
>>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>>> @@ -163,5 +163,10 @@
>>>>    			#size-cells = <0>;
>>>>    			ti,hwmods = "i2c3";
>>>>    		};
>>>> +
>>>> +		dcan1: d_can@481D0000 {
>>>
>>>      Address postfix in the node name and no "reg" property?
> 
>> This still works due to the hwmod mappings OMAP relies on.
> 
>     I.e. the "reg" property is populated in runtime?
> 
>> I would still
>> put it there, so the switch to real DT definitions will be less painful.
> 
>     How it helps anything?
> 

This is required field if you want to use "of_dev_auxdata", without
"reg" property OF layer fails to create dev_id (name) bindings with what
you have specified as part of "of_dev_auxdata".

And with respect to CAN driver, even though we are using hwmod, I would
want to create dev_id = d_can.0 and d_can.1. And this is only possible
if Address and compatible string matches.

So this field is important and required in this case.

Thanks,
Vaibhav

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[Koen Kooi]

Op 25 jul. 2012, om 14:23 heeft AnilKumar Ch <anilkumar@ti.com> het volgende geschreven:

> Add Bosch D_CAN controller device tree data to AM33XX dtsi file
> by adding d_can device node with all the necessary parameters.
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
> arch/arm/boot/dts/am33xx.dtsi |    5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 9b974dc..2db2ffb 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -163,5 +163,10 @@
> 			#size-cells = <0>;
> 			ti,hwmods = "i2c3";
> 		};
> +
> +		dcan1: d_can@481D0000 {
> +			compatible = "bosch,d_can";
> +			ti,hwmods = "d_can1";
> +		};
> 	};

I scanned the linux-networking mailinglist and l-o-ml, but I can't find the patchset that actually adds the d_can drivers, could you provide a link to that? I have 2 different CAN capes I'd like to test on beaglebone.

regards,

Koen

RE: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[AnilKumar, Chimata]

On Thu, Jul 26, 2012 at 14:16:33, Koen Kooi wrote:
> 
> Op 25 jul. 2012, om 14:23 heeft AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org> het volgende geschreven:
> 
> > Add Bosch D_CAN controller device tree data to AM33XX dtsi file
> > by adding d_can device node with all the necessary parameters.
> > 
> > Signed-off-by: AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org>
> > ---
> > arch/arm/boot/dts/am33xx.dtsi |    5 +++++
> > 1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index 9b974dc..2db2ffb 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -163,5 +163,10 @@
> > 			#size-cells = <0>;
> > 			ti,hwmods = "i2c3";
> > 		};
> > +
> > +		dcan1: d_can@481D0000 {
> > +			compatible = "bosch,d_can";
> > +			ti,hwmods = "d_can1";
> > +		};
> > 	};
> 
> I scanned the linux-networking mailinglist and l-o-ml, but I can't find the patchset that actually adds the d_can drivers, could you provide a link to that? I have 2 different CAN capes I'd like to test on beaglebone.
> 

You can find it from linux-next or net-next trees, D_CAN support is added
to C_CAN driver.

http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;
a=commitdiff;h=69927fccd96b15bd228bb82d356a7a2a0cfaeefb

Regards
AnilKumar

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 1741 bytes --]

On 07/26/2012 11:03 AM, AnilKumar, Chimata wrote:
> On Thu, Jul 26, 2012 at 14:16:33, Koen Kooi wrote:
>>
>> Op 25 jul. 2012, om 14:23 heeft AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org> het volgende geschreven:
>>
>>> Add Bosch D_CAN controller device tree data to AM33XX dtsi file
>>> by adding d_can device node with all the necessary parameters.
>>>
>>> Signed-off-by: AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org>
>>> ---
>>> arch/arm/boot/dts/am33xx.dtsi |    5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>>> index 9b974dc..2db2ffb 100644
>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>> @@ -163,5 +163,10 @@
>>> 			#size-cells = <0>;
>>> 			ti,hwmods = "i2c3";
>>> 		};
>>> +
>>> +		dcan1: d_can@481D0000 {
>>> +			compatible = "bosch,d_can";
>>> +			ti,hwmods = "d_can1";
>>> +		};
>>> 	};
>>
>> I scanned the linux-networking mailinglist and l-o-ml, but I can't find the patchset that actually adds the d_can drivers, could you provide a link to that? I have 2 different CAN capes I'd like to test on beaglebone.
>>
> 
> You can find it from linux-next or net-next trees, D_CAN support is added
> to C_CAN driver.
> 
> http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;
> a=commitdiff;h=69927fccd96b15bd228bb82d356a7a2a0cfaeefb

Meanwhile it's in Linus's git tree.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[Koen Kooi]

Op 26 jul. 2012, om 11:03 heeft "AnilKumar, Chimata" <anilkumar@ti.com> het volgende geschreven:

> On Thu, Jul 26, 2012 at 14:16:33, Koen Kooi wrote:
>> 
>> Op 25 jul. 2012, om 14:23 heeft AnilKumar Ch <anilkumar@ti.com> het volgende geschreven:
>> 
>>> Add Bosch D_CAN controller device tree data to AM33XX dtsi file
>>> by adding d_can device node with all the necessary parameters.
>>> 
>>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>>> ---
>>> arch/arm/boot/dts/am33xx.dtsi |    5 +++++
>>> 1 file changed, 5 insertions(+)
>>> 
>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>>> index 9b974dc..2db2ffb 100644
>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>> @@ -163,5 +163,10 @@
>>> 			#size-cells = <0>;
>>> 			ti,hwmods = "i2c3";
>>> 		};
>>> +
>>> +		dcan1: d_can@481D0000 {
>>> +			compatible = "bosch,d_can";
>>> +			ti,hwmods = "d_can1";
>>> +		};
>>> 	};
>> 
>> I scanned the linux-networking mailinglist and l-o-ml, but I can't find the patchset that actually adds the d_can drivers, could you provide a link to that? I have 2 different CAN capes I'd like to test on beaglebone.
>> 
> 
> You can find it from linux-next or net-next trees, D_CAN support is added
> to C_CAN driver.
> 
> http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;
> a=commitdiff;h=69927fccd96b15bd228bb82d356a7a2a0cfaeefb

Thanks! I'll try merging net-next into l-o master and see if I can get the CAN boards to work.

regards,

Koen

Re: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[Vaibhav Hiremath]

On 7/25/2012 5:53 PM, AnilKumar Ch wrote:
> Add Bosch D_CAN controller device tree data to AM33XX dtsi file
> by adding d_can device node with all the necessary parameters.
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
>  arch/arm/boot/dts/am33xx.dtsi |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 9b974dc..2db2ffb 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -163,5 +163,10 @@
>  			#size-cells = <0>;
>  			ti,hwmods = "i2c3";
>  		};
> +
> +		dcan1: d_can@481D0000 {
> +			compatible = "bosch,d_can";
> +			ti,hwmods = "d_can1";
> +		};

Anil,

Any reason why we are only specifying dcan1 instance? Shouldn't we
specify dcan0 as well here?

Thanks,
Vaibhav


>  	};
>  };
> 

RE: [PATCH v2 1/2] arm/dts: AM33XX: Add D_CAN device tree data

[AnilKumar, Chimata]

Vaibhav,

Thanks for the review.

On Fri, Aug 03, 2012 at 11:58:41, Hiremath, Vaibhav wrote:
> 
> 
> On 7/25/2012 5:53 PM, AnilKumar Ch wrote:
> > Add Bosch D_CAN controller device tree data to AM33XX dtsi file
> > by adding d_can device node with all the necessary parameters.
> > 
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > ---
> >  arch/arm/boot/dts/am33xx.dtsi |    5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index 9b974dc..2db2ffb 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -163,5 +163,10 @@
> >  			#size-cells = <0>;
> >  			ti,hwmods = "i2c3";
> >  		};
> > +
> > +		dcan1: d_can@481D0000 {
> > +			compatible = "bosch,d_can";
> > +			ti,hwmods = "d_can1";
> > +		};
> 
> Anil,
> 
> Any reason why we are only specifying dcan1 instance? Shouldn't we
> specify dcan0 as well here?
> 

Yes, I agree dcan0 needs to add because SoC support two instances. I
have added d_can1 only because on AM335x-EVM d_can1 is available and
in other case AM335x-bone have two instances available. I will send next
version of these patches.

Regards
AnilKumar

[PATCH v2 2/2] arm/dts: AM33XX: Configure pinmuxs for D_CAN1 on AM335x-EVM

[AnilKumar Ch]

Add D_CAN1 pinctrl node to am3358_pinmux master node to export
D_CAN functionality on AM335x EVM according to pinctrl-single
driver.

Signed-off-by: AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org>
---
 arch/arm/boot/dts/am335x-evm.dts |   13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index e4e1ccb..7f0fd6c 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -46,3 +46,16 @@
 	regulator-boot-on;
 	regulator-always-on;
 };
+
+&am3358_pinmux {
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&d_can1_pins>;
+
+	d_can1_pins: pinmux_d_can_pins {
+		pinctrl-single,pins = <
+			0x168 0x2	/* uart0_ctsn.d_can1_tx, OUTPUT | MODE2 */
+			0x16C 0x32	/* uart0_rtsn.d_can1_rx, INPUT_PULLUP | MODE2 */
+		>;
+	};
+};
-- 
1.7.9.5