Re: [PATCH 2/2] ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

[Konrad Dybcio <konrad.dybcio@linaro.org>]

On 26.06.2024 9:18 PM, Raymond Hackley wrote:
> Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the
> other Samsung devices based on MSM8226 with only a few minor differences.
> 
> The device trees contain initial support with:
>  - GPIO keys
>  - Regulator haptic
>  - SDHCI (internal and external storage)
>  - UART (on USB connector via the TI TSU6721 MUIC)
>  - Regulators
>  - Touchscreen
>  - Accelerometer
> 
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---

[...]

> +	reserved-memory {

'r' > 'g'

> +		smem_region: smem@fa00000 {
> +			reg = <0x0fa00000 0x100000>;
> +			no-map;
> +		};
> +	};
> +
> +	gpio-hall-sensor {

[...]

> +&sdhc_1 {
> +	vmmc-supply = <&pm8226_l17>;
> +	vqmmc-supply = <&pm8226_l6>;

At least vqmmc could use regulator-allow-set-load (this and below)

> +
> +	bus-width = <8>;
> +	non-removable;
> +
> +	status = "okay";
> +};
> +
> +&sdhc_2 {
> +	vmmc-supply = <&pm8226_l18>;
> +	vqmmc-supply = <&pm8226_l21>;
> +
> +	bus-width = <4>;
> +	cd-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>;
> +
> +	pinctrl-0 = <&sdhc2_default_state &sdhc2_cd_default>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +};

Konrad