From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tabi Timur-B04825 Subject: Re: [RFC:PATCH dtc-1.3.0] dtc: Add --strip-disabled option to dtc. Date: Wed, 15 Aug 2012 13:21:24 +0000 Message-ID: <502BA254.3050901@freescale.com> References: <1345034325-26656-1-git-send-email-srinivas.kandagatla@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1345034325-26656-1-git-send-email-srinivas.kandagatla-qxv4g6HH51o@public.gmane.org> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Srinivas KANDAGATLA Cc: "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "mmarek-AlSwsSmVLrQ@public.gmane.org" , "jdl-KZfg59tc24xl57MIdRCFDg@public.gmane.org" , "dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org" List-Id: devicetree@vger.kernel.org Srinivas KANDAGATLA wrote: > for_each_child(tree, child) { > + if (strip_disabled && !is_device_node_avaiable(child)) > + continue; > + > flatten_tree(child, emit, etarget, strbuf, vi); > } Since this function is recursive, children of disabled nodes will also be removed. You should document that. -- Timur Tabi Linux kernel developer at Freescale