devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: srinivas.kandagatla-qxv4g6HH51o@public.gmane.org
Cc: "mmarek-AlSwsSmVLrQ@public.gmane.org"
	<mmarek-AlSwsSmVLrQ@public.gmane.org>,
	Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	David Gibson <dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [RFC:PATCH dtc-1.3.0] dtc: Add --strip-disabled option to dtc.
Date: Fri, 17 Aug 2012 10:36:25 -0500	[thread overview]
Message-ID: <502E64F9.2020400@freescale.com> (raw)
In-Reply-To: <502E52F3.7090404-qxv4g6HH51o@public.gmane.org>

Srinivas KANDAGATLA wrote:
> If you know in advance that device on that SOC is broken, then I guess
> "Fail"/"Failed" can be used in status property.
> 
> One user of this flag in kernel device trees is
> ./arch/powerpc/boot/dts/mpc8313erdb.dts

	/* Remove this (or change to "okay") if you have
	 * a REVA3 or later board, if you apply one of the
	 * workarounds listed in section 8.5 of the board
	 * manual, or if you are adapting this device tree
	 * to a different board.
	 */
	status = "fail";

I'm not sure this is the right way to do it.  Normally, the boot loader
should be able to detect the board revision, and it should dynamically set
the 'status'.  We have other devices that fail if a work-around is not
applied, and we don't use this approach.

But assuming that this really is the best approach, then it would make
sense for --strip-disabled to leave this node in the dtb, because
otherwise there would be no way to re-enable it.

-- 
Timur Tabi
Linux kernel developer at Freescale

  parent reply	other threads:[~2012-08-17 15:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1345034325-26656-1-git-send-email-srinivas.kandagatla@st.com>
     [not found] ` <1345034325-26656-1-git-send-email-srinivas.kandagatla-qxv4g6HH51o@public.gmane.org>
2012-08-15 13:21   ` [RFC:PATCH dtc-1.3.0] dtc: Add --strip-disabled option to dtc Tabi Timur-B04825
2012-08-17  6:04   ` David Gibson
     [not found]     ` <20120817060415.GC29724-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-08-17  8:55       ` Srinivas KANDAGATLA
2012-08-17 12:16       ` Tabi Timur-B04825
     [not found]         ` <502E3632.70208-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-08-17 14:19           ` Srinivas KANDAGATLA
     [not found]             ` <502E52F3.7090404-qxv4g6HH51o@public.gmane.org>
2012-08-17 15:36               ` Timur Tabi [this message]
     [not found]                 ` <502E64F9.2020400-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-08-20  8:36                   ` Srinivas KANDAGATLA
     [not found]                     ` <5031F706.3050509-qxv4g6HH51o@public.gmane.org>
2012-08-20 12:37                       ` Tabi Timur-B04825
     [not found]                         ` <50322F9C.2070403-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-08-20 17:16                           ` Mitch Bradley
     [not found]                             ` <503270E1.6050902-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2012-08-21  0:09                               ` David Gibson
2012-08-20 15:59                       ` Scott Wood
     [not found]                         ` <50325ED4.2070403-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-08-20 16:01                           ` Timur Tabi
     [not found]                             ` <50325F60.9070106-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-08-20 16:06                               ` Scott Wood
     [not found]                                 ` <50326088.8060402-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-08-21  0:10                                   ` David Gibson
2012-08-21  0:11                       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502E64F9.2020400@freescale.com \
    --to=timur-kzfg59tc24xl57midrcfdg@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org \
    --cc=mmarek-AlSwsSmVLrQ@public.gmane.org \
    --cc=scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=srinivas.kandagatla-qxv4g6HH51o@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).