From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joy Chakraborty <joychakr@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: dwc3: Add binding for USB Gen2 de-emphasis
Date: Tue, 8 Oct 2024 14:10:08 +0200 [thread overview]
Message-ID: <502d7a1f-0bac-496f-8fbe-b8924cd0ce31@kernel.org> (raw)
In-Reply-To: <CAOSNQF0b--3o5bseU05Eu3a2zDiTTYfbnQNONFo3imw3HnaONA@mail.gmail.com>
On 08/10/2024 13:59, Joy Chakraborty wrote:
>>>
>>>>
>>>>> + description: When set core will set Tx de-emphasis for USB Gen2
>>>>
>>>> And why it cannot be implied by compatible?
>>>
>>> As per my understanding these are tuning coefficients for de-emphasis
>>> particular to a platform and not the dwc3 controller, hence should not
>>> be a controller compatible.
>>
>> Platforms must have specific compatible, so this should be implied by
>> compatible.
>
> Maybe I am using the word "platform" incorrectly here, what I
> understand is that the same controller(in a chip) when used on 2
> different physical form factors might need different deemphasis
You mean boards? This is board-level property?
> coefficient values to be passed to its Phy. Someone could correct me
> from the USB link stand point if I am mistaken here.
>
Then please point me to the upstream DTS boards using these properties.
Lore link is enough, if board or DTS change is being upstreamed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-08 12:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 13:55 [PATCH 0/2] usb: dwc3: Add USB3 Gen2 De-emphasis setting from DT Joy Chakraborty
2024-10-07 13:55 ` [PATCH 1/2] dt-bindings: usb: dwc3: Add binding for USB Gen2 de-emphasis Joy Chakraborty
2024-10-07 14:56 ` Krzysztof Kozlowski
2024-10-08 10:23 ` Joy Chakraborty
2024-10-08 11:23 ` Krzysztof Kozlowski
2024-10-08 11:59 ` Joy Chakraborty
2024-10-08 12:10 ` Krzysztof Kozlowski [this message]
2024-10-08 12:40 ` Joy Chakraborty
2024-10-08 12:59 ` Krzysztof Kozlowski
2024-10-07 13:55 ` [PATCH 1/2] dt-bindings: usb: dwc3: Add binding for USB Gen2 De-emphasis Joy Chakraborty
2024-10-07 13:55 ` [PATCH 2/2] usb: dwc3: Program USB Gen2 de-emphasis defined in PIPE4 spec Joy Chakraborty
2024-10-07 13:55 ` [PATCH 2/2] usb: dwc3: Program USB Gen2 De-emphasis " Joy Chakraborty
2024-10-16 8:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502d7a1f-0bac-496f-8fbe-b8924cd0ce31@kernel.org \
--to=krzk@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joychakr@google.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).