From: Michael Walle <michael@walle.cc>
To: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
Sudhanshu Gupta <sudhanshu.gupta@nxp.com>,
Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>,
Rai Harninder <harninder.rai@nxp.com>
Subject: Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register
Date: Thu, 07 Jan 2021 08:53:14 +0100 [thread overview]
Message-ID: <502fecda4d7f0d85e3417d16748e22f5@walle.cc> (raw)
In-Reply-To: <20210107064046.GF28365@dragon>
Hi Shawn,
Am 2021-01-07 07:40, schrieb Shawn Guo:
> On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote:
>> The offset of the reset request register is 0, the absolute address is
>> 0x1e60000. Boards without PSCI support will fail to perform a reset:
>>
>> [ 26.734700] reboot: Restarting system
>> [ 27.743259] Unable to restart system
>> [ 27.746845] Reboot failed -- System halted
>>
>> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
>> Signed-off-by: Michael Walle <michael@walle.cc>
>
> Out of curiosity, how did you get it fixed with your commit
> 3f0fb37b22b4
> ("arm64: dts: ls1028a: fix reboot node") in the first place?
I simply must have missed it. There is also a fallback reset method
via the watchdog in the chain, which kicks in if this wasn't successful.
So if you test it, it is easy to think its working although its not.
-michael
next prev parent reply other threads:[~2021-01-07 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 21:26 [PATCH] arm64: dts: ls1028a: fix the offset of the reset register Michael Walle
2021-01-07 6:40 ` Shawn Guo
2021-01-07 6:43 ` Shawn Guo
2021-01-07 7:53 ` Michael Walle [this message]
2021-01-10 12:00 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502fecda4d7f0d85e3417d16748e22f5@walle.cc \
--to=michael@walle.cc \
--cc=bhaskar.upadhaya@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=harninder.rai@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=sudhanshu.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox