From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
agross@kernel.org
Cc: andersson@kernel.org, konrad.dybcio@somainline.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, marijn.suijten@somainline.org,
kernel@collabora.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>
Subject: Re: [PATCH 2/2] soc: qcom: Add Qualcomm Ramp Controller driver
Date: Fri, 4 Nov 2022 10:29:49 -0400 [thread overview]
Message-ID: <50306718-fd3d-ae84-ffe8-d25daa64d956@linaro.org> (raw)
In-Reply-To: <5f3783a1-5e70-394d-1218-5969fb08c9c8@collabora.com>
On 04/11/2022 10:24, AngeloGioacchino Del Regno wrote:
> Il 04/11/22 15:22, Krzysztof Kozlowski ha scritto:
>> On 04/11/2022 10:18, AngeloGioacchino Del Regno wrote:
>>> Il 04/11/22 15:04, Krzysztof Kozlowski ha scritto:
>>>> On 04/11/2022 09:35, AngeloGioacchino Del Regno wrote:
>>>>> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>>>>>
>>>>> The Ramp Controller is used to program the sequence ID for pulse
>>>>> swallowing, enable sequence and linking sequence IDs for the CPU
>>>>> cores on some Qualcomm SoCs.
>>>>>
>>>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>>>>> ---
>>>>> drivers/soc/qcom/Kconfig | 9 +
>>>>> drivers/soc/qcom/Makefile | 1 +
>>>>> drivers/soc/qcom/ramp_controller.c | 330 +++++++++++++++++++++++++++++
>>>>> 3 files changed, 340 insertions(+)
>>>>> create mode 100644 drivers/soc/qcom/ramp_controller.c
>>>>>
>>>>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>>>>> index 024e420f1bb7..1e681f98bad4 100644
>>>>> --- a/drivers/soc/qcom/Kconfig
>>>>> +++ b/drivers/soc/qcom/Kconfig
>>>>> @@ -95,6 +95,15 @@ config QCOM_QMI_HELPERS
>>>>> tristate
>>>>> depends on NET
>>>>>
>>>>> +config QCOM_RAMP_CTRL
>>>>> + tristate "Qualcomm Ramp Controller driver"
>>>>> + depends on ARCH_QCOM
>>>>
>>>> I propose:
>>>> depends on ARCH_QCOM && ARM || COMPILE_TEST
>>>>
>>>> I don't think it is used on ARM64 SoCs, so let's make life of distros
>>>> easier.
>>>
>>> Forgot to reply to this one: MSM8956 and MSM8976 are ARM64 SoCs :-)
>>
>> Yeah, indeed, I meant the other way around, so && ARM&64 :)
>>
>
> I went too fast and sent out a v2 with ARCH_QCOM || COMPILE_TEST....
> ....should I go for a v3?
Wait a bit to collect feedback and then go with v3.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-04 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 13:35 [PATCH 0/2] Qualcomm Ramp Controller and MSM8976 config AngeloGioacchino Del Regno
2022-11-04 13:35 ` [PATCH 1/2] dt-bindings: soc: qcom: Add bindings for Qualcomm Ramp Controller AngeloGioacchino Del Regno
2022-11-04 14:00 ` Krzysztof Kozlowski
2022-11-04 14:12 ` AngeloGioacchino Del Regno
2022-11-04 13:35 ` [PATCH 2/2] soc: qcom: Add Qualcomm Ramp Controller driver AngeloGioacchino Del Regno
2022-11-04 14:04 ` Krzysztof Kozlowski
2022-11-04 14:06 ` AngeloGioacchino Del Regno
2022-11-04 14:18 ` AngeloGioacchino Del Regno
2022-11-04 14:22 ` Krzysztof Kozlowski
2022-11-04 14:24 ` AngeloGioacchino Del Regno
2022-11-04 14:29 ` Krzysztof Kozlowski [this message]
2022-11-04 22:16 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50306718-fd3d-ae84-ffe8-d25daa64d956@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).