From: Timur Tabi <timur-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: srinivas.kandagatla-qxv4g6HH51o@public.gmane.org
Cc: mmarek-AlSwsSmVLrQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH v2 dtc-1.3.0] dtc: Add --strip-disabled option to dtc(v2).
Date: Mon, 20 Aug 2012 11:09:12 -0500 [thread overview]
Message-ID: <50326128.6020202@freescale.com> (raw)
In-Reply-To: <5032557C.8020507-qxv4g6HH51o@public.gmane.org>
Srinivas KANDAGATLA wrote:
> I agree with you to some extent,
> But, Lets say a given SOC can support 5 UARTs But the board actually has
> only one wired up.
> Device tree for SOC has 5 entries for UART with disabled and only one
> UART is enabled by board level device tree.
> This is just once instance, think about SPI's, I2C, PWM's, Ethernets,
> memory devices... and other IP's which might wired up for particular boards.
It's true that in this case, the devices would be marked as "disabled" in
the DTS. Even using dtsi files won't help, because the board DTS file
will do something like this:
/include/ "uart1.dtsi"
soc: soc@e0000000 {
uart1: uart@1000 {
status = "disabled";
};
};
So I understand why you would want to remove disabled nodes completely. I
have no objection to your patch, but it's not my decision to make. I'm
not convinced, however, that it's a real problem. You're saving only a
10-20KB. Is that really a problem?
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-08-20 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 10:24 [PATCH v2 dtc-1.3.0] dtc: Add --strip-disabled option to dtc(v2) Srinivas KANDAGATLA
[not found] ` <1345458247-15701-1-git-send-email-srinivas.kandagatla-qxv4g6HH51o@public.gmane.org>
2012-08-20 13:25 ` Jon Loeliger
[not found] ` <E1T3RzA-0002rn-SS-CYoMK+44s/E@public.gmane.org>
2012-08-20 15:19 ` Srinivas KANDAGATLA
[not found] ` <5032557C.8020507-qxv4g6HH51o@public.gmane.org>
2012-08-20 16:09 ` Timur Tabi [this message]
2012-08-21 3:17 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50326128.6020202@freescale.com \
--to=timur-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org \
--cc=mmarek-AlSwsSmVLrQ@public.gmane.org \
--cc=srinivas.kandagatla-qxv4g6HH51o@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).