From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Subodh Nijsure <snijsure-4jo+YWezP1RWk0Htik3J/w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Dong Aisheng
<dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: Can one set GPIO direction in pinmux definition?
Date: Wed, 22 Aug 2012 13:52:45 -0600 [thread overview]
Message-ID: <5035388D.2060909@wwwdotorg.org> (raw)
In-Reply-To: <5034FCB2.5040709-4jo+YWezP1RWk0Htik3J/w@public.gmane.org>
On 08/22/2012 09:37 AM, Subodh Nijsure wrote:
>
> For a MX28 based hardware I am working with I need to use AUART4
>
> I need to configure this AUART4 as uart only when necessary and at all
> other times pins associated with AUART4 need to be configured as inputs.
Out of curiosity, why?
BTW, you didn't CC any of the IMX maintainers, so it's likely they won't
see your question. I've CC'd LinusW, Shawn, and Dong.
> I am using following DT definitions to setup AUART4 mux but can't
> figure out how to setup pin direction via DT, can it be done or I need
> to do it in C code?
>
> apb@80000000 {
> apbh@80000000 {
> auart4_pins_a: auart4@0 {
> reg = <0>;
> fsl,pinmux-ids = <
> 0x3142 /*
> MX28_PAD_SAIF0_MCLK__AUART4_CTS */
> 0x3152 /*
> MX28_PAD_SAIF0_LRCLK__AUART4_RTS */
> 0x3162 /*
> MX28_PAD_SAIF0_BITCLK__AUART4_RX */
> 0x3172 /*
> MX28_PAD_SAIF0_SDATA0__AUART4_TX */
> >;
> fsl,drive-strength = <0>;
> fsl,voltage = <1>;
> fsl,pull-up = <0>;
> };
> auart4_highz_pins: auart4-gpio@0 {
> reg = <0>;
> fsl,pinmux-ids = <
> 0x3143 /*
> MX28_PAD_SAIF0_MCLK__GPIO_3_20 */
> 0x3153 /*
> MX28_PAD_SAIF0_LRCLK__GPIO_3_21 */
> 0x3163 /*
> MX28_PAD_SAIF0_BITCLK__GPIO_3_22 */
> 0x3173 /*
> MX28_PAD_SAIF0_SDATA0__GPIO_3_23 */
> >;
> fsl,drive-strength = <0>;
> fsl,voltage = <1>;
> fsl,pull-up = <0>;
> };
> };
> };
I don't know IMX HW, but where is highz controlled? On other SoCs I'm
familiar with, when a pad is configured as a GPIO, the highz state is
controlled by the GPIO module, so there's nothing pinmux can do about
it. Even if the pinmux HW does control highz, gpio_direction_*() are
still meant to communicate with the pinctrl driver to implement this, so
overriding it through the pinctrl configuration seems like a bad thing.
So I think your UART driver would have to request the GPIOs, and set
them as inputs. So, I guess your UART node below would need a property
listing the GPIOs to do this to.
> apbx@80040000 {
> auart4: serial@80072000 {
> pinctrl-names = "default", "auart";
> pinctrl-0 = <&auart4_highz_pins>;
> pinctrl-1 = <&auart4_pins_a>;
> status = "okay";
> };
> };
next prev parent reply other threads:[~2012-08-22 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 15:37 Can one set GPIO direction in pinmux definition? Subodh Nijsure
[not found] ` <5034FCB2.5040709-4jo+YWezP1RWk0Htik3J/w@public.gmane.org>
2012-08-22 19:52 ` Stephen Warren [this message]
[not found] ` <5035388D.2060909-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-22 22:10 ` Subodh Nijsure
[not found] ` <503558B8.4010603-4jo+YWezP1RWk0Htik3J/w@public.gmane.org>
2012-08-22 23:18 ` Stephen Warren
2012-08-23 1:32 ` Shawn Guo
2012-08-23 0:17 ` Matt Sealey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5035388D.2060909@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=snijsure-4jo+YWezP1RWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).