From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: "AnilKumar, Chimata" <anilkumar-l0cyMroinI0@public.gmane.org>
Cc: "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org"
<rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
"linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"bryan.wu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org"
<bryan.wu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
"mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 5/5] of: Modify c_can binding documentation
Date: Sat, 01 Sep 2012 19:02:38 -0700 [thread overview]
Message-ID: <5042BE3E.8040808@wwwdotorg.org> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA234C7-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
On 09/01/2012 12:05 AM, AnilKumar, Chimata wrote:
> On Fri, Aug 31, 2012 at 14:59:21, AnilKumar, Chimata wrote:
>> Modify c_can binding documentation according to recent review comments
>> on device tree data addition patches.
>> diff --git a/Documentation/devicetree/bindings/net/can/c_can.txt b/Documentation/devicetree/bindings/net/can/c_can.txt
>> index a43f083..90a70be 100644
>> --- a/Documentation/devicetree/bindings/net/can/c_can.txt
>> +++ b/Documentation/devicetree/bindings/net/can/c_can.txt
>> @@ -8,6 +8,8 @@ Required properties:
>> registers map
>> - interrupts : property with a value describing the interrupt
>> number
>> +- status : describes the node status either "disabled" or
>> + "okay"
That's a standrd property that applies to any node, and doesn't describe
data required by the device itself (as do regs/interrupts) by simply
whether the node is activated; I'm not sure it's worth mentioning it in
a device-specific binding.
A similar comment exists for the pre-existing description of
interrupt-parent below.
>> Optional properties:
>> - interrupt-parent : The parent interrupt controller
next prev parent reply other threads:[~2012-09-02 2:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 9:29 [PATCH v5 0/5] Add device tree data for AM33XX devices AnilKumar Ch
2012-08-31 9:29 ` [PATCH v5 2/5] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone AnilKumar Ch
[not found] ` <1346405361-29711-1-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org>
2012-08-31 9:29 ` [PATCH v5 1/5] arm/dts: AM33XX: Add basic pinctrl device tree data AnilKumar Ch
2012-09-05 23:32 ` Tony Lindgren
[not found] ` <20120905233205.GO1303-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-09-06 6:17 ` AnilKumar, Chimata
2012-08-31 9:29 ` [PATCH v5 3/5] arm/dts: AM33XX: Add D_CAN " AnilKumar Ch
2012-08-31 9:29 ` [PATCH 4/5] leds: leds-gpio: adopt pinctrl support AnilKumar Ch
2012-08-31 16:04 ` Tony Lindgren
[not found] ` <20120831160402.GN1303-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-08-31 17:54 ` AnilKumar, Chimata
2012-08-31 9:29 ` [PATCH 5/5] of: Modify c_can binding documentation AnilKumar Ch
[not found] ` <1346405361-29711-6-git-send-email-anilkumar-l0cyMroinI0@public.gmane.org>
2012-09-01 7:05 ` AnilKumar, Chimata
[not found] ` <331ABD5ECB02734CA317220B2BBEABC13EA234C7-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2012-09-02 2:02 ` Stephen Warren [this message]
[not found] ` <5042BE3E.8040808-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-09-03 4:35 ` AnilKumar, Chimata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5042BE3E.8040808@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=anilkumar-l0cyMroinI0@public.gmane.org \
--cc=bryan.wu-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).