From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E161DC77B7E for ; Tue, 2 May 2023 10:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233280AbjEBKFT convert rfc822-to-8bit (ORCPT ); Tue, 2 May 2023 06:05:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230004AbjEBKFS (ORCPT ); Tue, 2 May 2023 06:05:18 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70B404EC0; Tue, 2 May 2023 03:05:15 -0700 (PDT) Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ptmsX-0006v1-8j; Tue, 02 May 2023 12:05:01 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Tianling Shen Cc: Rob Herring , Krzysztof Kozlowski , Jagan Teki , Peter Geis , Andy Yan , Chris Morgan , Brian Norris , Andrew Lunn , Shawn Guo , Bjorn Andersson , Sebastian Reichel , Maya Matuszczyk , Michael Riesch , Sascha Hauer , Vasily Khoruzhick , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Add Lunzn Fastrhino R66S Date: Tue, 02 May 2023 12:04:59 +0200 Message-ID: <5045149.1BCLMh4Saa@diego> In-Reply-To: References: <20230428013738.30735-1-cnsztl@gmail.com> <4763863.6tgchFWduM@diego> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Dienstag, 2. Mai 2023, 11:53:58 CEST schrieb Tianling Shen: > Hi Heiko, > > On Tue, May 2, 2023 at 5:30 PM Heiko Stübner wrote: > > > > Am Dienstag, 2. Mai 2023, 11:28:22 CEST schrieb Heiko Stübner: > > > Hi, > > > > > > Am Freitag, 28. April 2023, 03:37:37 CEST schrieb Tianling Shen: > > > > Lunzn Fastrhino R66S is a high-performance mini router. > > > > > > > > Specification: > > > > - Rockchip RK3568 > > > > - 1/2GB LPDDR4 RAM > > > > - SD card slot > > > > - M.2 Connector > > > > - 2x USB 3.0 Port > > > > - 2x 2500 Base-T (PCIe, r8125b) > > > > - 12v DC Jack > > > > > > > > Signed-off-by: Tianling Shen > > > > --- > > > > arch/arm64/boot/dts/rockchip/Makefile | 1 + > > > > .../dts/rockchip/rk3568-fastrhino-r66s.dts | 27 + > > > > .../dts/rockchip/rk3568-fastrhino-r66s.dtsi | 507 ++++++++++++++++++ > > > > 3 files changed, 535 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts > > > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dtsi > > > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > > > > index 2d585bbb8f3a..15089a78555a 100644 > > > > --- a/arch/arm64/boot/dts/rockchip/Makefile > > > > +++ b/arch/arm64/boot/dts/rockchip/Makefile > > > > @@ -85,6 +85,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb > > > > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-lubancat-2.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-nanopi-r5c.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-nanopi-r5s.dtb > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts b/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts > > > > new file mode 100644 > > > > index 000000000000..fc9e1bdab128 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r66s.dts > > > > @@ -0,0 +1,27 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > > > > + > > > > +#include "rk3568-fastrhino-r66s.dtsi" > > > > + > > > > +/ { > > > > + model = "Lunzn FastRhino R66S"; > > > > + compatible = "lunzn,fastrhino-r66s", "rockchip,rk3568"; > > > > + > > > > + aliases { > > > > + mmc0 = &sdmmc0; > > > > + }; > > > > +}; > > > > + > > > > +&sdmmc0 { > > > > > > that whole element seems to be duplicated from rk3568-fastrhino-r66s.dtsi? > > > I don't think we need to declare that twice. If something really changes, > > > please only declare the new properties when going from dtsi to dts. > > > > Looking at patch3 I see the explanation :-) . > > > > The base dtsi should not contain the &sdmmc0 node, and it should > > only be included in the rk3568-fastrhino-r66s.dts, right? > > > > Yes, nice catch! > > And I found another error in the R68S dts file (gmac pcfg pull type). > Unfortunately I don't have this board right now, and I'm still waiting > for the test result from my friend. Suppose sending v2 in the next few > days. no worries, send when you're ready :-) Heiko