From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Benoit Cousson <b-cousson@ti.com>
Cc: linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.infradead.org,
Vaibhav Hiremath <hvaibhav@ti.com>
Subject: Re: [PATCH 0/3] gpio-twl4030: add new device tree properties
Date: Mon, 03 Sep 2012 22:45:11 +0200 [thread overview]
Message-ID: <504516D7.3060101@epfl.ch> (raw)
In-Reply-To: <5044BE79.4040100@ti.com>
Hi Benoit,
> Nit #2: the DTS file does not belong to the gpio subsystem. So you
> should prefix them using the *convention* for ARM DTS patches:
>
> arm/dts: omap3: Add gpio-twl4030 properties for BeagleBoard and omap3-EVM
>
> Or maybe "ARM: dts: " because it looks like most people are using that
> nowadays.
>
> The convention for the gpio directory is similar:
> gpio/twl4030: get platform data from device tree
>
>> gpio-twl4030: updates the bindings for new dt properties
>>
>> .../devicetree/bindings/gpio/gpio-twl4030.txt | 6 ++
>> arch/arm/boot/dts/omap3-beagle.dts | 20 +++++
>> arch/arm/boot/dts/omap3-evm.dts | 13 +++
>> drivers/gpio/gpio-twl4030.c | 86 +++++++++++++------
>> 4 files changed, 98 insertions(+), 27 deletions(-)
> Thanks,
> Benoit
>
Thank you for your review, I will send a new version soon.
Regards,
Florian
next prev parent reply other threads:[~2012-09-03 20:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 13:54 [PATCH 0/3] gpio-twl4030: add new device tree properties Florian Vaussard
2012-09-03 13:54 ` [PATCH 1/3] gpio-twl4030: get platform data from device tree Florian Vaussard
2012-09-04 7:27 ` Vaibhav Hiremath
2012-09-05 7:10 ` Florian Vaussard
2012-09-04 7:30 ` Linus Walleij
2012-09-06 20:47 ` Tony Lindgren
2012-09-03 13:54 ` [PATCH 2/3] gpio-twl4030: new dt properties for BeagleBoard and omap3-EVM Florian Vaussard
2012-09-04 7:27 ` Vaibhav Hiremath
2012-09-04 7:30 ` Linus Walleij
2012-09-03 13:54 ` [PATCH 3/3] gpio-twl4030: updates the bindings for new dt properties Florian Vaussard
2012-09-04 7:31 ` Linus Walleij
2012-09-03 14:28 ` [PATCH 0/3] gpio-twl4030: add new device tree properties Benoit Cousson
2012-09-03 20:45 ` Florian Vaussard [this message]
[not found] ` <5044BE79.4040100-l0cyMroinI0@public.gmane.org>
2012-09-04 4:51 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504516D7.3060101@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=hvaibhav@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).