Re: [PATCH v2 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

["Duje Mihanović" <duje@dujemihanovic.xyz>]

On Sunday, 31 August 2025 21:24:54 Central European Summer Time Karel Balej wrote:
> Duje Mihanović, 2025-08-31T12:33:05+02:00:
> > +	if (IS_ERR(page))
> > +		return dev_err_probe(dev, PTR_ERR(page), "Failed to initialize GPADC
> > page\n"); +
> > +	gpadc->map = devm_regmap_init_i2c(page, &pm886_gpadc_regmap_config);
> > +	if (IS_ERR(gpadc->map))
> > +		return dev_err_probe(dev, PTR_ERR(gpadc->map),
> > +				     "Failed to initialize GPADC regmap\n");
> > +
> > +	iio->name = "88pm886-gpadc";
> > +	iio->dev.of_node = dev->parent->of_node;
> 
> Didn't you mean to drop this since Jonathan pointed out that it's done
> by the core?

Actually I have found that device tree consumers fail to get their IO
channels without this line, so I left it.

Regards,
--
Duje