From: Benoit Cousson <b-cousson@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Florian Vaussard <florian.vaussard@epfl.ch>,
Linus Walleij <linus.walleij@linaro.org>,
linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Grant Likely <grant.likely@secretlab.ca>,
Vaibhav Hiremath <hvaibhav@ti.com>,
Rob Herring <rob.herring@calxeda.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/2] gpio-twl4030: add new device tree properties
Date: Fri, 7 Sep 2012 10:55:43 +0200 [thread overview]
Message-ID: <5049B68F.4040003@ti.com> (raw)
In-Reply-To: <20120906205123.GL1303@atomide.com>
On 09/06/2012 10:51 PM, Tony Lindgren wrote:
> * Benoit Cousson <b-cousson@ti.com> [120905 07:42]:
>> Hi Florian,
>>
>> On 09/05/2012 09:46 AM, Florian Vaussard wrote:
>>> Hello,
>>>
>>> A number of platform data are missing when using twl4030/gpio from a
>>> device tree. This patchset adds the missing properties, updates the
>>> documentation with the new bindings, and updates existing device trees.
>>> It mainly enables LEDA and LEDB outputs, as well as pullups /
>>> pulldowns on GPIOs.
>>>
>>> The 1st patch changes the device driver and updates the documentation.
>>> The 2nd patch updates the device trees for BeagleBoard and omap3-evm.
>>>
>>> Changes since v1:
>>> - Patches on driver and documentation merged into the same patch
>>> - Put device trees' values in hexadecimal
>>> - Handle bool property using of_property_read_bool()
>>> - Prefix the patches with the correct convention
>>
>> Thanks for the update.
>>
>>> Tested on Gumstix Overo. V1 was tested on omap3-evm by Vaibhav Hiremath.
>>
>> I've just tested it on beagle xM. I can play with D12 led using:
>>
>> echo 255 > /sys/class/leds/beagleboard\:\:pmu_stat/brightness
>>
>> Tested-by: Benoit Cousson <b-cousson@ti.com>
>>
>>
>>> BTW: who will merge this?
>>
>> Since Linus already acked it, Tony can merge it.
>>
>>
>> Tony,
>>
>> I can add that series in my DTS series for 3.7 if you want.
>
> Yes please do thanks.
On top of that series, I realized that beagle was missing the other
LEDs. So I've just posted the support for the two missing ones.
[PATCH] ARM: dts: omap3-beagle: Add heartbeat and mmc LEDs support
Regards,
Benoit
prev parent reply other threads:[~2012-09-07 8:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 7:46 [PATCH v2 0/2] gpio-twl4030: add new device tree properties Florian Vaussard
2012-09-05 7:46 ` [PATCH 1/2] gpio/twl4030: get platform data from device tree Florian Vaussard
[not found] ` <1346831186-29947-2-git-send-email-florian.vaussard-p8DiymsW2f8@public.gmane.org>
2012-09-07 17:33 ` Benoit Cousson
2012-09-10 8:17 ` Florian Vaussard
2012-09-10 8:29 ` Benoit Cousson
[not found] ` <504DA503.5050901-l0cyMroinI0@public.gmane.org>
2012-09-10 8:40 ` Florian Vaussard
2012-09-05 7:46 ` [PATCH 2/2] ARM: dts: omap3: Add gpio-twl4030 properties for BeagleBoard and omap3-EVM Florian Vaussard
2012-09-05 14:41 ` [PATCH v2 0/2] gpio-twl4030: add new device tree properties Benoit Cousson
2012-09-06 20:51 ` Tony Lindgren
2012-09-07 8:55 ` Benoit Cousson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5049B68F.4040003@ti.com \
--to=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=florian.vaussard@epfl.ch \
--cc=grant.likely@secretlab.ca \
--cc=hvaibhav@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).