* [PATCH 0/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo @ 2012-09-10 13:16 Florian Vaussard 2012-09-10 13:16 ` [PATCH 1/1] " Florian Vaussard 0 siblings, 1 reply; 7+ messages in thread From: Florian Vaussard @ 2012-09-10 13:16 UTC (permalink / raw) To: Benoit Cousson Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-omap-u79uwXL29TY76Z2rM5mHXA, Steve Sakoman Hello, This patch adds the support for the blue LED connected to the LEDB pin of the TWL4030 on the Gumstix Overo when booting from the device tree. Build on top of Benoit's for_3.7/dts tree. Regards, Florian Florian Vaussard (1): ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo arch/arm/boot/dts/omap3-overo.dtsi | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) -- 1.7.5.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo 2012-09-10 13:16 [PATCH 0/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo Florian Vaussard @ 2012-09-10 13:16 ` Florian Vaussard [not found] ` <1347282996-31190-2-git-send-email-florian.vaussard-p8DiymsW2f8@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Florian Vaussard @ 2012-09-10 13:16 UTC (permalink / raw) To: Benoit Cousson Cc: Tony Lindgren, Steve Sakoman, linux-omap, devicetree-discuss, linux-arm-kernel, Florian Vaussard Support the blue LED connected to the LEDB pin of the TWL4030 on the Gumstix Overo. Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> --- arch/arm/boot/dts/omap3-overo.dtsi | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi index d6cc5e2..89808ce 100644 --- a/arch/arm/boot/dts/omap3-overo.dtsi +++ b/arch/arm/boot/dts/omap3-overo.dtsi @@ -13,6 +13,17 @@ /include/ "omap3.dtsi" +/ { + leds { + compatible = "gpio-leds"; + overo { + label = "overo:blue:COM"; + gpios = <&twl_gpio 19 0>; + linux,default-trigger = "mmc0"; + }; + }; +}; + &i2c1 { clock-frequency = <2600000>; @@ -40,3 +51,7 @@ &mmc2 { bus-width = <4>; }; + +&twl_gpio { + ti,use-leds; +}; -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <1347282996-31190-2-git-send-email-florian.vaussard-p8DiymsW2f8@public.gmane.org>]
* Re: [PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo [not found] ` <1347282996-31190-2-git-send-email-florian.vaussard-p8DiymsW2f8@public.gmane.org> @ 2012-09-10 13:25 ` Benoit Cousson 2012-09-10 13:33 ` Florian Vaussard 0 siblings, 1 reply; 7+ messages in thread From: Benoit Cousson @ 2012-09-10 13:25 UTC (permalink / raw) To: Florian Vaussard Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Steve Sakoman On 09/10/2012 03:16 PM, Florian Vaussard wrote: > Support the blue LED connected to the LEDB pin of the TWL4030 > on the Gumstix Overo. > > Signed-off-by: Florian Vaussard <florian.vaussard-p8DiymsW2f8@public.gmane.org> > --- > arch/arm/boot/dts/omap3-overo.dtsi | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi > index d6cc5e2..89808ce 100644 > --- a/arch/arm/boot/dts/omap3-overo.dtsi > +++ b/arch/arm/boot/dts/omap3-overo.dtsi > @@ -13,6 +13,17 @@ > > /include/ "omap3.dtsi" > > +/ { BTW, I'm just wondering. Cannot we use overo without tobi? In that case, the model and compatible should probably be used as well: model = "TI OMAP3 Gumstix Overo"; compatible = "ti,omap3-overo", "ti,omap3"; > + leds { > + compatible = "gpio-leds"; > + overo { > + label = "overo:blue:COM"; > + gpios = <&twl_gpio 19 0>; > + linux,default-trigger = "mmc0"; > + }; > + }; > +}; > + > &i2c1 { > clock-frequency = <2600000>; > > @@ -40,3 +51,7 @@ > &mmc2 { > bus-width = <4>; > }; > + > +&twl_gpio { > + ti,use-leds; > +}; > Otherwise, it is fine. Thanks, Benoit ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo 2012-09-10 13:25 ` Benoit Cousson @ 2012-09-10 13:33 ` Florian Vaussard 2012-09-10 13:40 ` Benoit Cousson 0 siblings, 1 reply; 7+ messages in thread From: Florian Vaussard @ 2012-09-10 13:33 UTC (permalink / raw) To: Benoit Cousson Cc: Tony Lindgren, Steve Sakoman, linux-omap, devicetree-discuss, linux-arm-kernel >> Support the blue LED connected to the LEDB pin of the TWL4030 >> on the Gumstix Overo. >> >> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> >> --- >> arch/arm/boot/dts/omap3-overo.dtsi | 15 +++++++++++++++ >> 1 files changed, 15 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi >> index d6cc5e2..89808ce 100644 >> --- a/arch/arm/boot/dts/omap3-overo.dtsi >> +++ b/arch/arm/boot/dts/omap3-overo.dtsi >> @@ -13,6 +13,17 @@ >> >> /include/ "omap3.dtsi" >> >> +/ { > > BTW, I'm just wondering. Cannot we use overo without tobi? > > In that case, the model and compatible should probably be used as well: > > model = "TI OMAP3 Gumstix Overo"; > compatible = "ti,omap3-overo", "ti,omap3"; No, it cannot. The Overo needs to be plugged into an expansion board, at least to get the power. Hence the absence of model and compatible in omap3-overo.dtsi. Regards, Florian ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo 2012-09-10 13:33 ` Florian Vaussard @ 2012-09-10 13:40 ` Benoit Cousson [not found] ` <504DEDB4.1070804-l0cyMroinI0@public.gmane.org> 2012-09-10 14:07 ` Florian Vaussard 0 siblings, 2 replies; 7+ messages in thread From: Benoit Cousson @ 2012-09-10 13:40 UTC (permalink / raw) To: florian.vaussard Cc: Tony Lindgren, Steve Sakoman, linux-omap, devicetree-discuss, linux-arm-kernel On 09/10/2012 03:33 PM, Florian Vaussard wrote: >>> Support the blue LED connected to the LEDB pin of the TWL4030 >>> on the Gumstix Overo. >>> >>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> >>> --- >>> arch/arm/boot/dts/omap3-overo.dtsi | 15 +++++++++++++++ >>> 1 files changed, 15 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi >>> b/arch/arm/boot/dts/omap3-overo.dtsi >>> index d6cc5e2..89808ce 100644 >>> --- a/arch/arm/boot/dts/omap3-overo.dtsi >>> +++ b/arch/arm/boot/dts/omap3-overo.dtsi >>> @@ -13,6 +13,17 @@ >>> >>> /include/ "omap3.dtsi" >>> >>> +/ { >> >> BTW, I'm just wondering. Cannot we use overo without tobi? >> >> In that case, the model and compatible should probably be used as well: >> >> model = "TI OMAP3 Gumstix Overo"; >> compatible = "ti,omap3-overo", "ti,omap3"; > > No, it cannot. The Overo needs to be plugged into an expansion board, at > least to get the power. Hence the absence of model and compatible in > omap3-overo.dtsi. OK, cool. I was wondering because we already have a board-overo.c in the kernel, and there is no mention of tobi. OK, I'm adding that patch on top of the other then. Regards, Benoit ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <504DEDB4.1070804-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo [not found] ` <504DEDB4.1070804-l0cyMroinI0@public.gmane.org> @ 2012-09-10 13:49 ` Benoit Cousson 0 siblings, 0 replies; 7+ messages in thread From: Benoit Cousson @ 2012-09-10 13:49 UTC (permalink / raw) To: florian.vaussard-p8DiymsW2f8 Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Steve Sakoman On 09/10/2012 03:40 PM, Benoit Cousson wrote: > On 09/10/2012 03:33 PM, Florian Vaussard wrote: >>>> Support the blue LED connected to the LEDB pin of the TWL4030 >>>> on the Gumstix Overo. >>>> >>>> Signed-off-by: Florian Vaussard <florian.vaussard-p8DiymsW2f8@public.gmane.org> >>>> --- >>>> arch/arm/boot/dts/omap3-overo.dtsi | 15 +++++++++++++++ >>>> 1 files changed, 15 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi >>>> b/arch/arm/boot/dts/omap3-overo.dtsi >>>> index d6cc5e2..89808ce 100644 >>>> --- a/arch/arm/boot/dts/omap3-overo.dtsi >>>> +++ b/arch/arm/boot/dts/omap3-overo.dtsi >>>> @@ -13,6 +13,17 @@ >>>> >>>> /include/ "omap3.dtsi" >>>> >>>> +/ { >>> >>> BTW, I'm just wondering. Cannot we use overo without tobi? >>> >>> In that case, the model and compatible should probably be used as well: >>> >>> model = "TI OMAP3 Gumstix Overo"; >>> compatible = "ti,omap3-overo", "ti,omap3"; >> >> No, it cannot. The Overo needs to be plugged into an expansion board, at >> least to get the power. Hence the absence of model and compatible in >> omap3-overo.dtsi. > > OK, cool. I was wondering because we already have a board-overo.c in the > kernel, and there is no mention of tobi. > > OK, I'm adding that patch on top of the other then. I'm just going to update the subject to: ARM: dts: omap3-overo: Add support for the blue LED regards, Benoit ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo 2012-09-10 13:40 ` Benoit Cousson [not found] ` <504DEDB4.1070804-l0cyMroinI0@public.gmane.org> @ 2012-09-10 14:07 ` Florian Vaussard 1 sibling, 0 replies; 7+ messages in thread From: Florian Vaussard @ 2012-09-10 14:07 UTC (permalink / raw) To: Benoit Cousson Cc: Tony Lindgren, Steve Sakoman, linux-omap, devicetree-discuss, linux-arm-kernel >>> >>> BTW, I'm just wondering. Cannot we use overo without tobi? >>> >>> In that case, the model and compatible should probably be used as well: >>> >>> model = "TI OMAP3 Gumstix Overo"; >>> compatible = "ti,omap3-overo", "ti,omap3"; >> >> No, it cannot. The Overo needs to be plugged into an expansion board, at >> least to get the power. Hence the absence of model and compatible in >> omap3-overo.dtsi. > > OK, cool. I was wondering because we already have a board-overo.c in the > kernel, and there is no mention of tobi. In board-overo.c, the various features of each expansion board are configured using CONFIG_* options, which is not possible when booting with a device tree. Regards, Florian ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-09-10 14:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-10 13:16 [PATCH 0/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo Florian Vaussard
2012-09-10 13:16 ` [PATCH 1/1] " Florian Vaussard
[not found] ` <1347282996-31190-2-git-send-email-florian.vaussard-p8DiymsW2f8@public.gmane.org>
2012-09-10 13:25 ` Benoit Cousson
2012-09-10 13:33 ` Florian Vaussard
2012-09-10 13:40 ` Benoit Cousson
[not found] ` <504DEDB4.1070804-l0cyMroinI0@public.gmane.org>
2012-09-10 13:49 ` Benoit Cousson
2012-09-10 14:07 ` Florian Vaussard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).