From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH] of: specify initrd location using 64-bit Date: Wed, 12 Sep 2012 21:58:29 +0200 Message-ID: <5050E965.5080405@linutronix.de> References: <1347465937-7056-1-git-send-email-cyril@ti.com> <5050CE33.9060909@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5050CE33.9060909@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Cyril Chemparathy Cc: Geert Uytterhoeven , devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux@openrisc.net, linuxppc-dev@lists.ozlabs.org, microblaze-uclinux@itee.uq.edu.au, a-jacquiot@ti.com, arnd@arndb.de, benh@kernel.crashing.org, blogic@openwrt.org, david.daney@cavium.com, dhowells@redhat.com, grant.likely@secretlab.ca, hpa@zytor.com, jonas@southpole.se, linus.walleij@linaro.org, linux@arm.linux.org.uk, m.szyprowski@samsung.com, mahesh@linux.vnet.ibm.com, mingo@redhat.com, monstr@monstr.eu, msalter@redhat.com, nico@linaro.org, paul.gortmaker@windriver.com, paulus@samba.org, ralf@linux-mips.org, rob.herring@calxeda.com, suzuki@in.ibm.com, tglx@linutronix.de, tj@kernel.org, x86@kernel.org List-Id: devicetree@vger.kernel.org On 09/12/2012 08:02 PM, Cyril Chemparathy wrote: >>> -void __init early_init_dt_setup_initrd_arch(unsigned long start, >>> unsigned long end) >>> +void __init early_init_dt_setup_initrd_arch(u64 start, u64 end) >> >> Why not phys_addr_t? >> > > The rest of the memory specific bits of the device-tree code use u64 for > addresses, and I kept it the same for consistency. Geert is right here. If it is a physical address, it should be phys_addr_t. Sebastian