From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7963132ABCD;
	Mon,  2 Mar 2026 10:36:59 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1772447822; cv=none; b=uAak8WKnI0Sieoj+JYmGIUoy2iQZJrCXXbZGo4d5t5I7I836Qf5FnCXn3VBy55Uw2tC1T1AOE7hFWFReqY4wsHt146k4crE2VH6WV9kLHUwxxQvTirmmxPtMSxmvwSqI2oWz+cFRZj+dmQg4wkYDW5JXE0NoV8XSDcIAKkgSqH4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1772447822; c=relaxed/simple;
	bh=kO11BKmKFYoC09eco+6dmdwTd3OQRCC8tF7pTfHduz0=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=tYwKCmwacnxgkNoWWF8N5H0f+LOCPd6adupcEQephaPlizYT8NA9CMKsR2vlh71/WVWqkN4KfpH9yq5lTJv5OXcvPn34OA8KhVTVBpD4BDB5U4QxLq5pYKd5MYvPuWa5uiiAnDU3ifof6UNG0VMbWvc980xNkymYHKP5uViZnNQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=EKp0nFdi; arc=none smtp.client-ip=185.11.138.130
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="EKp0nFdi"
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de;
	s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To;
	bh=kO11BKmKFYoC09eco+6dmdwTd3OQRCC8tF7pTfHduz0=; b=EKp0nFdi5sCj9Lg7x8UsS+uiqc
	uOvigeWC9f4WnNKIN4GhoQw2dIh6fy7FDYFCbKnU/BNYLRbxws6nPC7s/rEmjkgmWtVT2qypJS6gE
	dSF84nfAkxRlqNyP86G63N5Ly7nfyn6gi3VYt479afbCYyC7CSljkjfZ3hhyrMagc6HHw1qyOmncN
	qH67492d+MY9KH43uYzR/wO0arMiOe/1VsHZK2Guye+xehGUYaiMgxPdCbXJsduK7c/P1pjB4ZEL5
	MWiykNb/FfbPcqLWjTIIFfXoSWW+Xnao4VUjXPfbxZhGJY+ylhYwamAaFx0+UAnk1SC28k0LNdI+N
	yFzfzckw==;
From: Heiko Stuebner <heiko@sntech.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
 devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject:
 Re: [PATCH 1/2] ARM: dts: rockchip: rk3036: Move PHY reset to ethernet-phy
 node
Date: Mon, 02 Mar 2026 11:36:42 +0100
Message-ID: <5051965.GXAFRqVoOG@phil>
In-Reply-To:
 <CAOMZO5CfmS2UEd8JwbR7WHRhTVR4m6cOZUBxhXWAf2zxNhY-Fw@mail.gmail.com>
References:
 <20260228013257.256973-1-festevam@gmail.com> <2819870.mvXUDI8C0e@phil>
 <CAOMZO5CfmS2UEd8JwbR7WHRhTVR4m6cOZUBxhXWAf2zxNhY-Fw@mail.gmail.com>
Precedence: bulk
X-Mailing-List: devicetree@vger.kernel.org
List-Id: <devicetree.vger.kernel.org>
List-Subscribe: <mailto:devicetree+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:devicetree+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Hey Fabio,

Am Samstag, 28. Februar 2026, 13:15:52 Mitteleurop=C3=A4ische Normalzeit sc=
hrieb Fabio Estevam:
> Hi Heiko,
>=20
> On Sat, Feb 28, 2026 at 8:40=E2=80=AFAM Heiko Stuebner <heiko@sntech.de> =
wrote:
>=20
> > please don't send patches that "simply" fix devicetree warnings.
> >
> > As you can see in [0] the driver uses these properties currently.
> > So while this fixes schema warnings, it will break the actual boards.
> >
> > So first of all you'll need to adapt the driver to handle the "official"
> > properties and also provide a fallback in the driver for old devicetree=
s.
>=20
> The rk3066a-rayeager board describes the reset-gpios inside the
> Ethernet PHY node:
>=20
> https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/rockchip/=
rk3066a-rayeager.dts#L155-L157
>=20
> Is this broken?

No it isn't :-) .

That's what I get when I try looking at patches on a saturday before
coffee ;-) .

With the reset moving into the phy-node, the phy driver will trigger its
reset itself of course. The arc-mdio also request the reset-gpio as
optional, so the whole thing won't fail if te gpio is not present.

Sorry about the noise, the patch is correct obviously.


Heiko