From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 4/7] dt/powerpc/sysdev: Use of_get_child_by_name to get a named child. Date: Fri, 14 Sep 2012 08:05:52 -0500 Message-ID: <50532BB0.3090502@gmail.com> References: <1347610764-20227-1-git-send-email-srinivas.kandagatla@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1347610764-20227-1-git-send-email-srinivas.kandagatla-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Srinivas KANDAGATLA Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On 09/14/2012 03:19 AM, Srinivas KANDAGATLA wrote: > From: Srinivas Kandagatla > > As follow-up to "dt: introduce of_get_child_by_name to get child node by > name." patch, This patch removes some of the code duplication in the > driver by replacing it with of_get_child_by_name instead. > > Signed-off-by: Srinivas Kandagatla > --- > arch/powerpc/sysdev/qe_lib/qe.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c > index b043675..fd1c15d 100644 > --- a/arch/powerpc/sysdev/qe_lib/qe.c > +++ b/arch/powerpc/sysdev/qe_lib/qe.c > @@ -568,10 +568,7 @@ struct qe_firmware_info *qe_get_firmware_info(void) > } > > /* Find the 'firmware' child node */ > - for_each_child_of_node(qe, fw) { > - if (strcmp(fw->name, "firmware") == 0) > - break; > - } > + fw = of_get_child_by_name(qe "firmware"); Missing comma. > > of_node_put(qe); > >