From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>,
Maen Suleiman <maen@marvell.com>,
Ben Dooks <ben.dooks@codethink.co.uk>,
linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: [PATCH v3 2/5] Documentation: add description of DT binding for the gpio-mvebu driver
Date: Sun, 16 Sep 2012 11:11:44 +0200 [thread overview]
Message-ID: <505597D0.6030200@gmail.com> (raw)
In-Reply-To: <20120916075601.GN28177@lunn.ch>
On 09/16/2012 09:56 AM, Andrew Lunn wrote:
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-mvebu.txt
>> @@ -0,0 +1,45 @@
>> +* Marvell EBU GPIO controller
>> ...
>> +- interrupt-controller: identifies the node as an interrupt controller
>> +
>> +- #interrupt-cells: specifies the number of celles needed to encode an
>> + interrupt source
>
> Hi Thomas
>
> Should this be #gpio-cells? The example below does not have
> #interrupt-cells?
It should be both. #gpio-cells to encode pin-offset within the gpio controller
and polarity, #interrupt-cells to encode irq number.
Sebastian
next prev parent reply other threads:[~2012-09-16 9:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 15:54 [PATCH v4] gpio: mvebu: new gpio driver for mvebu platforms Thomas Petazzoni
2012-09-13 15:54 ` [PATCH v3 1/5] gpio: introduce gpio-mvebu driver for Marvell SoCs Thomas Petazzoni
[not found] ` <1347551658-24449-2-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2012-09-14 13:15 ` Linus Walleij
2012-09-13 15:54 ` [PATCH v3 2/5] Documentation: add description of DT binding for the gpio-mvebu driver Thomas Petazzoni
[not found] ` <1347551658-24449-3-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2012-09-13 20:20 ` Rob Herring
2012-09-13 20:30 ` Thomas Petazzoni
2012-09-13 20:34 ` Rob Herring
[not found] ` <50524363.9070100-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-14 13:17 ` Linus Walleij
2012-09-14 14:54 ` Thomas Petazzoni
2012-09-14 23:46 ` Jason Cooper
2012-09-14 22:00 ` Stephen Warren
2012-09-16 7:56 ` Andrew Lunn
2012-09-16 9:11 ` Sebastian Hesselbarth [this message]
2012-09-13 15:54 ` [PATCH v3 3/5] arm: mvebu: use GPIO support now that a driver is available Thomas Petazzoni
2012-09-13 15:54 ` [PATCH v3 4/5] arm: mvebu: add DT information for GPIO banks on Armada 370 and XP Thomas Petazzoni
[not found] ` <1347551658-24449-5-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2012-09-14 22:01 ` Stephen Warren
2012-09-13 15:54 ` [PATCH v3 5/5] arm: mvebu: add gpio support in defconfig Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505597D0.6030200@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=ben.dooks@codethink.co.uk \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=maen@marvell.com \
--cc=rob.herring@calxeda.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).