From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sagar Cheluvegowda <quic_scheluve@quicinc.com>,
Vinod Koul <vkoul@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: kernel@quicinc.com, Andrew Halaney <ahalaney@redhat.com>,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: net: qcom: ethernet: Add interconnect properties
Date: Thu, 20 Jun 2024 09:12:02 +0200 [thread overview]
Message-ID: <505739da-6724-4928-bea8-f03d673544bc@kernel.org> (raw)
In-Reply-To: <20240619-icc_bw_voting_from_ethqos-v1-3-6112948b825e@quicinc.com>
On 20/06/2024 00:41, Sagar Cheluvegowda wrote:
> Add documentation for the interconnect and interconnect-names
> properties required when voting for AHB and AXI buses.
>
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
> ---
> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 6672327358bc..bf2a197342a5 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -63,6 +63,14 @@ properties:
>
> dma-coherent: true
>
> + interconnects:
> + maxItems: 2
> +
> + interconnect-names:
> + items:
> + - const: axi_icc_path
> + - const: ahb_icc_path
Drop "_icc_path", redundant and instead describe it like other bindings.
Also, names use hyphens. Just open any Qualcomm DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-20 7:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 22:41 [PATCH 0/3] Add interconnect support for qcom_ethqos driver Sagar Cheluvegowda
2024-06-19 22:41 ` [PATCH 1/3] net: stmmac: Add interconnect support in qcom-ethqos driver Sagar Cheluvegowda
2024-06-19 23:13 ` Andrew Lunn
2024-06-21 19:22 ` Sagar Cheluvegowda
2024-06-21 20:01 ` Andrew Lunn
2024-06-21 20:44 ` Andrew Halaney
2024-06-20 7:12 ` Krzysztof Kozlowski
2024-06-19 22:41 ` [PATCH 2/3] net: stmmac: Bring down the clocks to lower frequencies when mac link goes down Sagar Cheluvegowda
2024-06-19 22:41 ` [PATCH 3/3] dt-bindings: net: qcom: ethernet: Add interconnect properties Sagar Cheluvegowda
2024-06-20 7:12 ` Krzysztof Kozlowski [this message]
2024-06-19 23:03 ` [PATCH 0/3] Add interconnect support for qcom_ethqos driver Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505739da-6724-4928-bea8-f03d673544bc@kernel.org \
--to=krzk@kernel.org \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_scheluve@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).