From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] gpio: Describe interrupt-controller binding Date: Tue, 18 Sep 2012 08:28:16 -0500 Message-ID: <505876F0.6010809@gmail.com> References: <1347958274-19425-1-git-send-email-thierry.reding@avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1347958274-19425-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Thierry Reding Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Linus Walleij , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 09/18/2012 03:51 AM, Thierry Reding wrote: > In order to use GPIO controllers as interrupt controllers, they need to > be marked with the DT interrupt-controller property. This commit adds > some documentation about this to the general GPIO binding document. > > Cc: Linus Walleij > Cc: Grant Likely > Cc: Rob Herring > Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: Thierry Reding Applied for 3.7. Rob > --- > Documentation/devicetree/bindings/gpio/gpio.txt | 33 +++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt > index 4e16ba4..8d125b0 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio.txt > +++ b/Documentation/devicetree/bindings/gpio/gpio.txt > @@ -75,4 +75,37 @@ Example of two SOC GPIO banks defined as gpio-controller nodes: > gpio-controller; > }; > > +If the GPIO controller supports the generation of interrupts, it should > +also contain an empty "interrupt-controller" property as well as an > +"#interrupt-cells" property. This is required in order for other nodes > +to use the GPIO controller as their interrupt parent. > > +If #interrupt-cells is 1, the single cell is used to specify the number > +of the GPIO that is to be used as an interrupt. > + > +If #interrupt-cells is 2, the first cell is used to specify the number > +of the GPIO that is to be used as an interrupt, whereas the second cell > +is used to specify any of the following flags: > + - bits[3:0] trigger type and level flags > + 1 = low-to-high edge triggered > + 2 = high-to-low edge triggered > + 4 = active high level-sensitive > + 8 = active low level-sensitive > + > +Example: > + > + gpioext: gpio-controller@41 { > + compatible = "ad,gpio-adnp"; > + reg = <0x41>; > + > + interrupt-parent = <&gpio>; > + interrupts = <160 1>; > + > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + > + nr-gpios = <64>; > + }; >