From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>,
mchehab@kernel.org, linux-media@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: dt: adv7604: Fix slave map documentation
Date: Wed, 8 Aug 2018 09:48:00 +0200 [thread overview]
Message-ID: <505904fb-7bfc-c455-740e-b72a14731eb9@ysoft.com> (raw)
In-Reply-To: <20180807155452.797-1-kieran.bingham@ideasonboard.com>
On 7.8.2018 17:54, Kieran Bingham wrote:
Hi Kieran,
> The reg-names property in the documentation is missing an '='. Add it.
>
> Fixes: 9feb786876c7 ("media: dt-bindings: media: adv7604: Extend
> bindings to allow specifying slave map addresses")
>
"dt-bindings: media: " is preferred for the subject.
I think you should also add device tree maintainers to the recipients.
Best regards,
Michal
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/i2c/adv7604.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> index dcf57e7c60eb..b3e688b77a38 100644
> --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt
> @@ -66,7 +66,7 @@ Example:
> * other maps will retain their default addresses.
> */
> reg = <0x4c>, <0x66>;
> - reg-names "main", "edid";
> + reg-names = "main", "edid";
>
> reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>;
> hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>;
>
next prev parent reply other threads:[~2018-08-08 7:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 15:54 [PATCH] media: dt: adv7604: Fix slave map documentation Kieran Bingham
2018-08-08 7:48 ` Michal Vokáč [this message]
2018-08-08 10:23 ` Kieran Bingham
2018-08-08 10:25 ` Laurent Pinchart
2018-08-08 12:33 ` Michal Vokáč
2018-08-08 12:51 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505904fb-7bfc-c455-740e-b72a14731eb9@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=devicetree@vger.kernel.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).