* [PATCH v2] of: dma: fix typos in generic dma binding definition
@ 2012-09-19 14:49 Matt Porter
2012-09-19 15:26 ` Arnd Bergmann
2012-09-24 22:27 ` Jon Hunter
0 siblings, 2 replies; 3+ messages in thread
From: Matt Porter @ 2012-09-19 14:49 UTC (permalink / raw)
To: Jon Hunter
Cc: Devicetree Discuss, Linux OMAP List, Linux ARM Kernel List,
Nicolas Ferre, Stephen Warren, Grant Likely, Benoit Cousson,
Russell King, Rob Herring, Arnd Bergmann, Vinod Koul,
Dan Williams
Some semicolons were left out in the examples.
The #dma-channels and #dma-requests properties have a prefix
that is, by convention, reserved for cell size properties.
Rename those properties to dma-channels and dma-requests.
Signed-off-by: Matt Porter <mporter@ti.com>
---
Documentation/devicetree/bindings/dma/dma.txt | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/dma.txt b/Documentation/devicetree/bindings/dma/dma.txt
index a4f59a5..8f504e6 100644
--- a/Documentation/devicetree/bindings/dma/dma.txt
+++ b/Documentation/devicetree/bindings/dma/dma.txt
@@ -13,22 +13,22 @@ Required property:
more details.
Optional properties:
-- #dma-channels: Number of DMA channels supported by the controller.
-- #dma-requests: Number of DMA requests signals supported by the
+- dma-channels: Number of DMA channels supported by the controller.
+- dma-requests: Number of DMA requests signals supported by the
controller.
Example:
dma: dma@48000000 {
- compatible = "ti,omap-sdma"
+ compatible = "ti,omap-sdma";
reg = <0x48000000 0x1000>;
interrupts = <0 12 0x4
0 13 0x4
0 14 0x4
0 15 0x4>;
#dma-cells = <1>;
- #dma-channels = <32>;
- #dma-requests = <127>;
+ dma-channels = <32>;
+ dma-requests = <127>;
};
@@ -61,7 +61,7 @@ Examples:
...
dmas = <&dma 2 /* read channel */
&dma 3>; /* write channel */
- dma-names = "rx", "tx"
+ dma-names = "rx", "tx";
...
};
@@ -70,7 +70,7 @@ Examples:
dmas = <&dma1 5
&dma2 7
&dma3 2>;
- dma-names = "rx-tx", "rx-tx", "rx-tx"
+ dma-names = "rx-tx", "rx-tx", "rx-tx";
3. A device with three channels, one of which has two alternatives:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] of: dma: fix typos in generic dma binding definition
2012-09-19 14:49 [PATCH v2] of: dma: fix typos in generic dma binding definition Matt Porter
@ 2012-09-19 15:26 ` Arnd Bergmann
2012-09-24 22:27 ` Jon Hunter
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2012-09-19 15:26 UTC (permalink / raw)
To: Matt Porter
Cc: Jon Hunter, Devicetree Discuss, Linux OMAP List,
Linux ARM Kernel List, Nicolas Ferre, Stephen Warren,
Grant Likely, Benoit Cousson, Russell King, Rob Herring,
Vinod Koul, Dan Williams
On Wednesday 19 September 2012, Matt Porter wrote:
>
> Some semicolons were left out in the examples.
>
> The #dma-channels and #dma-requests properties have a prefix
> that is, by convention, reserved for cell size properties.
> Rename those properties to dma-channels and dma-requests.
>
> Signed-off-by: Matt Porter <mporter@ti.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] of: dma: fix typos in generic dma binding definition
2012-09-19 14:49 [PATCH v2] of: dma: fix typos in generic dma binding definition Matt Porter
2012-09-19 15:26 ` Arnd Bergmann
@ 2012-09-24 22:27 ` Jon Hunter
1 sibling, 0 replies; 3+ messages in thread
From: Jon Hunter @ 2012-09-24 22:27 UTC (permalink / raw)
To: Matt Porter
Cc: Devicetree Discuss, Linux OMAP List, Linux ARM Kernel List,
Nicolas Ferre, Stephen Warren, Grant Likely, Benoit Cousson,
Russell King, Rob Herring, Arnd Bergmann, Vinod Koul,
Dan Williams
Hi Matt,
On 09/19/2012 09:49 AM, Matt Porter wrote:
> Some semicolons were left out in the examples.
>
> The #dma-channels and #dma-requests properties have a prefix
> that is, by convention, reserved for cell size properties.
> Rename those properties to dma-channels and dma-requests.
>
> Signed-off-by: Matt Porter <mporter@ti.com>
Acked-by: Jon Hunter <jon-hunter@ti.com>
Thanks for catching and fixing these!
Cheers
Jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-24 22:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-19 14:49 [PATCH v2] of: dma: fix typos in generic dma binding definition Matt Porter
2012-09-19 15:26 ` Arnd Bergmann
2012-09-24 22:27 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).