From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7529C77B7A for ; Tue, 6 Jun 2023 12:29:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231883AbjFFM3f (ORCPT ); Tue, 6 Jun 2023 08:29:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229835AbjFFM3f (ORCPT ); Tue, 6 Jun 2023 08:29:35 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9529010C7 for ; Tue, 6 Jun 2023 05:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1686054572; x=1717590572; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IoROUOZF8CE9WZ6SE+5jmL2spAKJFIqqLTf0QJmwNlI=; b=fyGYTVs96VCoySTRj0PQUNY7cLP/is2kuDryFw+jwOP03S1qKLllGO8I BJoQl6gSKp7WUMljAg7YN0HudfU1Puq8yiXWd/iHKgKyousXqUd0wL12S 26wFCnLdhLyi6q1Sf6XEZ8fsP7oW9lefx/+0bYObsSLzEobFWSD2lTIQR ICPDc5mbZ6IBlMam1sPsTWL/A0BBFFkr5f/Sff8SBUEkpAR0/ba4CffCS ZUU7AKuJBvcoQR7AU/HnaRzL917acVML7KiOvgwUhoIUck05oh9yUB0vb PpuvlqfAYpoomYGy9vL0a6nHbUJwQey88GzvcKTA1RCi+SErsons0a1J3 Q==; X-IronPort-AV: E=Sophos;i="6.00,221,1681164000"; d="scan'208";a="31303690" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 06 Jun 2023 14:29:30 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 06 Jun 2023 14:29:30 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 06 Jun 2023 14:29:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1686054570; x=1717590570; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IoROUOZF8CE9WZ6SE+5jmL2spAKJFIqqLTf0QJmwNlI=; b=lrIN4e88aCItbFptWSGElrYUvJ18XKhfXeIicj0pCswiJwN37hUesxBy PVKtWxg4PweMs5bOxHklkf4lAacaZTiM5k06YMm/D8dkaMXPdlVgK7ubg +Zz/0c/MQAwsmqHZTLRTRzlfeAdwExOvBPWN2Xg4aJX+g6QUP8VgJCCLY quWhI7Lk8zsONWw+pPqgFerS0Gec8Wb2auxL+fVtYUdGmHo7c2/th8J4X 0nEm4GpAXe2jiKeXXBkGQJgCJbWn6cQ5N7gZY0L6hmhYQeI8c6JlyJ/9x hXKSpwospqsOXTd01gl0BFge3crfYqZ6MHi1DaV+nriAZTIT0qsuHxTwd g==; X-IronPort-AV: E=Sophos;i="6.00,221,1681164000"; d="scan'208";a="31303688" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 06 Jun 2023 14:29:30 +0200 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 0B851280090; Tue, 6 Jun 2023 14:29:30 +0200 (CEST) From: Alexander Stein To: Marco Felsch Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Catalin Marinas , Will Deacon , Markus Niebel , "devicetree@vger.kernel.org" , NXP Linux Team , Pengutronix Kernel Team , "linux-arm-kernel@lists.infradead.org" , "linux@ew.tq-group.com" Subject: Re: [PATCH 1/3] dt-bindings: arm: add TQMa8Xx boards Date: Tue, 06 Jun 2023 14:29:30 +0200 Message-ID: <5061585.GXAFRqVoOG@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230606120730.6exdpylr24qn6hdw@pengutronix.de> References: <20230606112108.685885-1-alexander.stein@ew.tq-group.com> <20230606112108.685885-2-alexander.stein@ew.tq-group.com> <20230606120730.6exdpylr24qn6hdw@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marco, thanks for the feedback. Am Dienstag, 6. Juni 2023, 14:07:56 CEST schrieb Marco Felsch: > Hi Alexander, >=20 > On 23-06-06, Alexander Stein wrote: > > TQMa8Xx is a SOM series featuring NXP i.MX8X SoC. > > They are called TQMa8XQP and TQMa8XDP respectively. > > MBa8Xx is an evaluation mainboard for this SOM > >=20 > > Signed-off-by: Markus Niebel > > Signed-off-by: Alexander Stein > > --- > >=20 > > Documentation/devicetree/bindings/arm/fsl.yaml | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > b/Documentation/devicetree/bindings/arm/fsl.yaml index > > 2510eaa8906dd..c4dcdac43bafb 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > >=20 > > @@ -1195,6 +1195,23 @@ properties: > > - const: toradex,colibri-imx8x > > - const: fsl,imx8qxp > >=20 > > + - description: > > + TQMa8Xx is a series of SOM featuring NXP i.MX8X system-on-ch= ip > > + variants. It is designed to be clicked on different carrier > > boards + MBa8Xx is the starterkit > > + oneOf: > > + - items: > > + - enum: > > + - tq,imx8dxp-tqma8xdp-mba8xx # TQ-Systems GmbH TQMa8= XDP > > SOM on MBa8Xx + - const: tq,imx8dxp-tqma8xdp # > > TQ-Systems GmbH TQMa8XDP SOM (with i.MX8DXP) + - const: > > fsl,imx8dxp > > + - const: fsl,imx8qxp >=20 > ^ > Should be removed? The rest lgtm, so feel free to add my: As imx8dxp is missing completely, I think it's even better the not add this= =20 compatible for now. > Reviewed-by: Marco Felsch Thanks, you meant this for this patch only or the whole series? > Nit: Please check the dts(i) files for C++ comments '//' and replace > them with '/**/'. There was at least one C++ comment. Ah, you are right. Thanks. Regards, Alexander > Regards, > Marco >=20 > > + - items: > > + - enum: > > + - tq,imx8qxp-tqma8xqp-mba8xx # TQ-Systems GmbH TQMa8= XQP > > SOM on MBa8Xx + - const: tq,imx8qxp-tqma8xqp # > > TQ-Systems GmbH TQMa8XQP SOM (with i.MX8QXP) + - const: > > fsl,imx8qxp > > + > >=20 > > - description: i.MX8ULP based Boards > > =20 > > items: > > - enum: =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/