From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Markus Mayer" Subject: Re: [PATCH 1/1] Fix segfault in DTC Date: Wed, 26 Sep 2012 09:38:16 -0700 Message-ID: <50632F78.4030709@broadcom.com> References: <1348526885-2113-1-git-send-email-mmayer@broadcom.com> <1348595889-6495-1-git-send-email-mmayer@broadcom.com> <1348595889-6495-2-git-send-email-mmayer@broadcom.com> <20120925233054.GL9800@truffula.fritz.box> <50624393.30607@broadcom.com> <20120926003508.GB31993@truffula.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120926003508.GB31993-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: David Gibson Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 25/09/2012 17:35, David Gibson wrote: > On Tue, Sep 25, 2012 at 04:51:47PM -0700, Markus Mayer wrote: >> On 25/09/2012 16:30, David Gibson wrote: >>> >>> Which dtc version did you observe this with? I'm unable to reproduce >>> the SEGV with current git. >> >> That was >> >> $ cat version_gen.h >> #define DTC_VERSION "DTC 1.2.0-g37c0b6a0" >> >> from >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git. In >> other words, the DTC used by the Linux 3.6-rc series. > > Ah, ok. Patches to dtc should be made against the upstream version at > git://git.jdl.com/software/dtc.git. In this case the bug was already > fixed there, in commit a6e6c60e3a97a6b3a033cd052bb3740fd53cbf4c. Ah yes. That makes sense. Thanks for pointing out the commit that fixes the issue. I just checked it out. > I think we're overdue to update the kernel copy of dtc from upstream. Yeah, seems like the kernel DTC is quite old. Regards, -Markus