From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Joe Perches <joe@perches.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
akpm@linux-foundation.org, davem@davemloft.net,
santosh.shilimkar@ti.com, grant.likely@secretlab.ca,
balbi@ti.com, arnd@arndb.de, gregkh@linuxfoundation.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, robherring2@gmail.com,
richard.zhao@freescale.com, B29397@freescale.com,
alexander.shishkin@linux.intel.com, marex@denx.de,
p.paneri@samsung.com, devicetree-discuss@lists.ozlabs.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] drivers: phy: add generic PHY framework
Date: Wed, 26 Sep 2012 20:01:42 +0200 [thread overview]
Message-ID: <50634306.8050702@pengutronix.de> (raw)
In-Reply-To: <2573688.gCRJ0R3vnc@dtor-d630.eng.vmware.com>
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
On 09/26/2012 07:41 PM, Dmitry Torokhov wrote:
> On Wednesday, September 26, 2012 09:57:57 AM Joe Perches wrote:
>> On Wed, 2012-09-26 at 20:31 +0530, Kishon Vijay Abraham I wrote:
>>> The PHY framework provides a set of API's for the PHY drivers to
>>> create/destroy a PHY and API's
>>
>> Just some trivial notes.
>>
>>> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
>>
>> []
>>
>>> @@ -0,0 +1,445 @@
>>
>> []
>>
>>> +static void devm_phy_release(struct device *dev, void *res)
>>> +{
>>> + struct phy *phy = *(struct phy **)res;
>>
>> That's a bit twisted isn't it?
>> Perhaps
>> struct phy *phy = res;
>
> No, because you really need to dereference ptr, not simply cast.
To avoid this confusion I suggest to create a struct phy_res. For now
its only member will be a pointer to a struct phy.
>
> ...
>
>>> +
>>> + ptr = devres_alloc(devm_phy_release, sizeof(*ptr), GFP_KERNEL);
>>
>> Is this the right size?
>>
>> Because ptr is **, perhaps sizeof(struct phy) is clearer.
>
> But incorrect.
A proper struct will make the code more readable here, too.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2012-09-26 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 15:01 [PATCH] drivers: phy: add generic PHY framework Kishon Vijay Abraham I
2012-09-26 16:57 ` Joe Perches
2012-09-26 17:41 ` Dmitry Torokhov
2012-09-26 18:01 ` Marc Kleine-Budde [this message]
2012-09-26 17:04 ` Greg KH
2012-09-26 17:08 ` David Miller
2012-09-26 20:07 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50634306.8050702@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=B29397@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marex@denx.de \
--cc=p.paneri@samsung.com \
--cc=richard.zhao@freescale.com \
--cc=robherring2@gmail.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).