From: Sekhar Nori <nsekhar@ti.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: "Philip, Avinash" <avinashphilip@ti.com>,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
rob@landley.net, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
gururaja.hebbar@ti.com
Subject: Re: [PATCH 1/2] pwm: pwm-tiecap: Add device-tree binding support for APWM driver
Date: Tue, 2 Oct 2012 12:46:16 +0530 [thread overview]
Message-ID: <506A94C0.1010106@ti.com> (raw)
In-Reply-To: <20121002060014.GA4298@avionic-0098.mockup.avionic-design.de>
Hi Thierry,
On 10/2/2012 11:30 AM, Thierry Reding wrote:
> On Wed, Sep 26, 2012 at 04:57:42PM +0530, Philip, Avinash wrote:
> [...]
>> +#include <linux/platform_data/ti-pwmss.h>
> [...]
>> +static struct pwmss_platform_data am33xx_data = {
>> + .has_configspace = true,
>> +};
>
> This structure is defined in a public header. I don't see why it has to,
> given that it's only used to associate some data with an of_device_id
> entry below. Since AM33xx never had anything but OF support in the
> mainline kernel I don't think we should add platform data.
Avinash probably introduced platform data because the same PWM IP is
used in older DaVinci family SoCs (DA830 and DA850) which are not
converted to DT. There are existing boards for those SoCs (supported in
mainline) which could benefit from this driver.
Thanks,
Sekhar
next prev parent reply other threads:[~2012-10-02 7:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 11:27 [PATCH 0/2] DT binding support for ECAP & EHRPWM driver Philip, Avinash
2012-09-26 11:27 ` [PATCH 1/2] pwm: pwm-tiecap: Add device-tree binding support for APWM driver Philip, Avinash
2012-10-02 6:00 ` Thierry Reding
2012-10-02 7:16 ` Sekhar Nori [this message]
[not found] ` <506A94C0.1010106-l0cyMroinI0@public.gmane.org>
2012-10-02 8:07 ` Thierry Reding
[not found] ` <20121002080751.GA16928-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-10-02 8:27 ` Sekhar Nori
2012-10-08 13:31 ` Philip, Avinash
2012-10-08 13:39 ` Thierry Reding
2012-10-09 12:36 ` Philip, Avinash
2012-10-09 12:48 ` Thierry Reding
2012-09-26 11:27 ` [PATCH 2/2] pwm: pwm-tiehrpwm: Add device-tree binding support for EHRPWM driver Philip, Avinash
[not found] ` <1348658863-29428-3-git-send-email-avinashphilip-l0cyMroinI0@public.gmane.org>
2012-10-02 6:11 ` Thierry Reding
2012-10-08 13:31 ` Philip, Avinash
2012-10-08 13:50 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506A94C0.1010106@ti.com \
--to=nsekhar@ti.com \
--cc=avinashphilip@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gururaja.hebbar@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).